From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:38760 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbdELITP (ORCPT ); Fri, 12 May 2017 04:19:15 -0400 From: Kalle Valo To: Xie Qirong Cc: Arend van Spriel , Franky Lin , Hante Meuleman , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer References: <20170512073555.12333-1-cheerx1994@gmail.com> Date: Fri, 12 May 2017 11:19:06 +0300 In-Reply-To: <20170512073555.12333-1-cheerx1994@gmail.com> (Xie Qirong's message of "Fri, 12 May 2017 15:35:55 +0800") Message-ID: <87tw4qqyh1.fsf@kamboji.qca.qualcomm.com> (sfid-20170512_101952_841647_28E6ADC8) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Xie Qirong writes: > The combination of init_timer and setting up the data and function field > manually is equivalent to calling setup_timer(). This is an api > consolidation only and improves readability. > > Acked-by: Arend van Spriel > Signed-off-by: Xie Qirong > --- > > setup_timer.cocci suggested the following improvement: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use > setup_timer function for function on line 384. > > Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + > CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + > CONFIG_BRCMDBG=y > > Kernel version: 4.11.0 (localversion-next is next-20170512) How is this different from the first version? https://patchwork.kernel.org/patch/9709467/ Always add patch version "[PATCH v2]" and a changelog. I added a section "Frequent problems" to the wiki to mention about these common problems: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing -- Kalle Valo