Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: <yhchuang@realtek.com>
Cc: <linux-wireless@vger.kernel.org>, <briannorris@chromium.org>
Subject: Re: [PATCH 02/10] rtw88: Enable 802.11ac beamformee support
Date: Mon, 14 Oct 2019 12:38:36 +0300
Message-ID: <87v9srfyzn.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <20191008082101.2494-3-yhchuang@realtek.com> (yhchuang's message of "Tue, 8 Oct 2019 16:20:53 +0800")

<yhchuang@realtek.com> writes:

> From: Tzu-En Huang <tehuang@realtek.com>
>
> Enable MU-MIMO transmit beamformee support for chipset 8822b and 8822c.
>
> If the rtw88 is in station mode and associated with an AP, and the
> capabilities of both meet the requirement of beamforming, driver will
> run as a beamformee and the corresponding chip settings will be set.
>
> In addition, module parameter support_bf is added to enable or disable
> beamforming.

Why do you need a module parameter? Module paramaters are not meant to
be replacement for ini files, where you have a setting to enable or
disable each future. Module parameters should be added only for really
good reasons.

> +void rtw_bf_assoc(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
> +		  struct ieee80211_bss_conf *bss_conf)
> +{
> +	struct ieee80211_hw *hw = rtwdev->hw;
> +	struct rtw_vif *rtwvif = (struct rtw_vif *)vif->drv_priv;
> +	struct rtw_bfee *bfee = &rtwvif->bfee;
> +	struct rtw_bf_info *bfinfo = &rtwdev->bf_info;
> +	struct rtw_chip_info *chip = rtwdev->chip;
> +	struct ieee80211_sta *sta;
> +	struct ieee80211_sta_vht_cap vht_cap;
> +	struct ieee80211_sta_vht_cap ic_vht_cap;
> +	u32 sound_dim;
> +	u8 *bssid, i;
> +
> +	if (chip->band & RTW_BAND_5G) {
> +		ic_vht_cap = hw->wiphy->bands[NL80211_BAND_5GHZ]->vht_cap;
> +		if (!(ic_vht_cap.cap &
> +		      (IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE |
> +		       IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE)))
> +			goto exit;
> +	} else {
> +		goto exit;
> +	}
> +
> +	bssid = (u8 *)bss_conf->bssid;

This cast looks very fishy, you are again casting away const. Like I
said in patch 1, avoid casts as much as possible. They are fragile and
can easily create bugs if you are not careful.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08  8:20 [PATCH 00/10] rtw88: minor throughput improvement yhchuang
2019-10-08  8:20 ` [PATCH 01/10] rtw88: add power tracking support yhchuang
2019-10-09  8:17   ` Kalle Valo
2019-10-08  8:20 ` [PATCH 02/10] rtw88: Enable 802.11ac beamformee support yhchuang
2019-10-14  9:38   ` Kalle Valo [this message]
2019-10-08  8:20 ` [PATCH 03/10] rtw88: config 8822c multicast address in MAC init flow yhchuang
2019-10-14  9:08   ` Kalle Valo
2019-10-08  8:20 ` [PATCH 04/10] rtw88: add set_bitrate_mask support yhchuang
2019-10-08  8:20 ` [PATCH 05/10] rtw88: update regulatory settings implementaion yhchuang
2019-10-14  9:39   ` Kalle Valo
2019-10-08  8:20 ` [PATCH 06/10] rtw88: add NL80211_EXT_FEATURE_CAN_REPLACE_PTK0 support yhchuang
2019-10-14  9:11   ` Kalle Valo
2019-10-08  8:20 ` [PATCH 07/10] rtw88: Use rtw_write8_set to set SYS_FUNC yhchuang
2019-10-08  8:20 ` [PATCH 08/10] rtw88: pci: config phy after chip info is setup yhchuang
2019-10-08  8:21 ` [PATCH 09/10] rtw88: coex: Set 4 slot mode for A2DP yhchuang
2019-10-08  8:21 ` [PATCH 10/10] rtw88: add phy_info debugfs to show Tx/Rx physical status yhchuang
2019-10-14  9:45 ` [PATCH 00/10] rtw88: minor throughput improvement Kalle Valo
2019-10-15  3:23   ` Tony Chuang

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9srfyzn.fsf@tynnyri.adurom.net \
    --to=kvalo@codeaurora.org \
    --cc=briannorris@chromium.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git