Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: kbuild test robot <lkp@intel.com>
Cc: Tzu-En Huang <tehuang@realtek.com>,
	kbuild-all@01.org, Yan-Hsuan Chuang <yhchuang@realtek.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtw88: 8822c: fix boolreturn.cocci warnings
Date: Fri, 13 Sep 2019 23:29:46 +0300
Message-ID: <87v9twc539.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190913173221.cgz7jdi5ggbfummj@48261080c7f1>

kbuild test robot <lkp@intel.com> writes:

> From: kbuild test robot <lkp@intel.com>
>
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2606:9-10: WARNING: return of 0/1 in function 'rtw8822c_dpk_coef_iq_check' with return type bool
>
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: 5227c2ee453d ("rtw88: 8822c: add SW DPK support")
> CC: Tzu-En Huang <tehuang@realtek.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>
> tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
> head:   f9e568754562e0f506e12aa899c378b4155080e9
> commit: 5227c2ee453d2f778192d8bb0f1a6072892aaa8e [23/32] rtw88: 8822c: add SW DPK support
>
>  rtw8822c.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> @@ -2603,9 +2603,9 @@ static bool rtw8822c_dpk_coef_iq_check(s
>  {
>  	if (coef_i == 0x1000 || coef_i == 0x0fff ||
>  	    coef_q == 0x1000 || coef_q == 0x0fff)
> -		return 1;
> +		return true;
>  	else
> -		return 0;
> +		return false;

Can someone submit this to linux-wireless so that patchwork can see it,
please?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

       reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201909140114.9pMJS5nZ%lkp@intel.com>
     [not found] ` <20190913173221.cgz7jdi5ggbfummj@48261080c7f1>
2019-09-13 20:29   ` Kalle Valo [this message]
2019-09-16  2:41 yhchuang

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9twc539.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=kbuild-all@01.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=tehuang@realtek.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox