From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 975A4C49ED7 for ; Fri, 13 Sep 2019 20:29:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63BE120717 for ; Fri, 13 Sep 2019 20:29:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="n6MrWAaq"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="SNX4KNba" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388167AbfIMU3x (ORCPT ); Fri, 13 Sep 2019 16:29:53 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36194 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387637AbfIMU3x (ORCPT ); Fri, 13 Sep 2019 16:29:53 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 55CB8607F4; Fri, 13 Sep 2019 20:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568406592; bh=etafjzTA6Zi879lr6Ovwc5pyqqqoiOtwlPwoiVSGFJI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=n6MrWAaqmN1xuck78P6Klx6Ee40HY6mvHJlyE9Ibhyyz+QgbvgPLG9TLY0DM+SRl/ 7iLHIvmt0yjpE+UapI+wuERQX5DClbeVXYTHORP9C5n3GbNSoqMIZgDOJvAiQ5KRXH 8kFyOE0BKjF7iHcB+1wJ6l39pmdDJyq1lv9PmmHA= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 20F8C60769; Fri, 13 Sep 2019 20:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568406591; bh=etafjzTA6Zi879lr6Ovwc5pyqqqoiOtwlPwoiVSGFJI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SNX4KNbaXjQpOmrNB++Ct/TqJd17gtJui+qGc9JXT/4oHv0XpFkQVGeUv30BOpHdN UXnjAjJWG03noDLnFxK6Ik1TssLZP3sBPqTGTqjHa6qGlyfEz+g9ms3zTaydD9c1dM 2CRH7Q7ULR/EsHL8Vn4/M8L92iRNWc0u8aWGrDPE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 20F8C60769 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: kbuild test robot Cc: Tzu-En Huang , kbuild-all@01.org, Yan-Hsuan Chuang , linux-wireless@vger.kernel.org Subject: Re: [PATCH] rtw88: 8822c: fix boolreturn.cocci warnings References: <201909140114.9pMJS5nZ%lkp@intel.com> <20190913173221.cgz7jdi5ggbfummj@48261080c7f1> Date: Fri, 13 Sep 2019 23:29:46 +0300 In-Reply-To: <20190913173221.cgz7jdi5ggbfummj@48261080c7f1> (kbuild test robot's message of "Sat, 14 Sep 2019 01:32:21 +0800") Message-ID: <87v9twc539.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org kbuild test robot writes: > From: kbuild test robot > > drivers/net/wireless/realtek/rtw88/rtw8822c.c:2606:9-10: WARNING: return of 0/1 in function 'rtw8822c_dpk_coef_iq_check' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Fixes: 5227c2ee453d ("rtw88: 8822c: add SW DPK support") > CC: Tzu-En Huang > Signed-off-by: kbuild test robot > --- > > tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master > head: f9e568754562e0f506e12aa899c378b4155080e9 > commit: 5227c2ee453d2f778192d8bb0f1a6072892aaa8e [23/32] rtw88: 8822c: add SW DPK support > > rtw8822c.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c > @@ -2603,9 +2603,9 @@ static bool rtw8822c_dpk_coef_iq_check(s > { > if (coef_i == 0x1000 || coef_i == 0x0fff || > coef_q == 0x1000 || coef_q == 0x0fff) > - return 1; > + return true; > else > - return 0; > + return false; Can someone submit this to linux-wireless so that patchwork can see it, please? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches