From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@qti.qualcomm.com>
Cc: Ben Greear <greearb@candelatech.com>,
Wen Gong <wgong@codeaurora.org>,
"ath10k\@lists.infradead.org" <ath10k@lists.infradead.org>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: add mic bytes for pmf management packet
Date: Wed, 24 Jul 2019 15:10:42 +0300 [thread overview]
Message-ID: <87v9vrzl8d.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <9403fef58374427fa76fb32ee64ee333@aptaiexm02f.ap.qualcomm.com> (Wen Gong's message of "Tue, 18 Jun 2019 07:21:30 +0000")
Wen Gong <wgong@qti.qualcomm.com> writes:
>> -----Original Message-----
>> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Ben
>> Greear
>> Sent: Tuesday, June 18, 2019 12:04 AM
>> To: Wen Gong <wgong@codeaurora.org>; ath10k@lists.infradead.org
>> Cc: linux-wireless@vger.kernel.org
>> Subject: [EXT] Re: [PATCH] ath10k: add mic bytes for pmf management
>> packet
>>
>> I was looking at mac80211 code recently, and it seems some action
>> frames are NOT supposed to be protected. I added my own helper
>> method to my local ath10k. Maybe you want to use this?
>>
>>
>> /* Copied from ieee80211_is_robust_mgmt_frame, but disable the check for
>> has_protected
>> * since we do tx hw crypt, and it won't actually be encrypted even when this
>> flag is
>> * set.
>> */
>> bool ieee80211_is_robust_mgmt_frame_tx(struct ieee80211_hdr *hdr)
>> {
>> if (ieee80211_is_disassoc(hdr->frame_control) ||
>> ieee80211_is_deauth(hdr->frame_control))
>> return true;
>>
>> if (ieee80211_is_action(hdr->frame_control)) {
>> u8 *category;
>>
>> /*
>> * Action frames, excluding Public Action frames, are Robust
>> * Management Frames. However, if we are looking at a Protected
>> * frame, skip the check since the data may be encrypted and
>> * the frame has already been found to be a Robust Management
>> * Frame (by the other end).
>> */
>> /*
>> if (ieee80211_has_protected(hdr->frame_control))
>> return true;
>> */
>> category = ((u8 *) hdr) + 24;
>> return *category != WLAN_CATEGORY_PUBLIC &&
>> *category != WLAN_CATEGORY_HT &&
>> *category != WLAN_CATEGORY_WNM_UNPROTECTED &&
>> *category != WLAN_CATEGORY_SELF_PROTECTED &&
>> *category != WLAN_CATEGORY_UNPROT_DMG &&
>> *category != WLAN_CATEGORY_VHT &&
>> *category != WLAN_CATEGORY_VENDOR_SPECIFIC;
>> }
>>
>> return false;
>> }
>>
>> Thanks,
>> Ben
>>
>> > +
>> > data_len = msdu->len;
>> >
>> > switch (txmode) {
>> >
>>
>>
> Thanks Ben,
>
> seems the ieee80211_is_robust_mgmt_frame_tx is not
> match my change.
So what's the conclusion, can I take this patch?
--
Kalle Valo
next prev parent reply other threads:[~2019-07-24 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 7:37 [PATCH] ath10k: add mic bytes for pmf management packet Wen Gong
2019-06-17 16:03 ` Ben Greear
2019-06-18 7:21 ` Wen Gong
2019-07-24 12:10 ` Kalle Valo [this message]
2019-07-25 2:15 ` Wen Gong
2019-09-10 13:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9vrzl8d.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
--cc=wgong@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).