From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Christian Lamparter <chunkeey@web.de>
Subject: Re: [PATCH v2] cfg80211: fix deadlock
Date: Mon, 17 Aug 2009 18:31:33 +0300 [thread overview]
Message-ID: <87vdkmtq22.fsf@litku.valot.fi> (raw)
In-Reply-To: <1250504737.15103.1.camel@johannes.local> (Johannes Berg's message of "Mon\, 17 Aug 2009 12\:25\:37 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> When removing an interface with nl80211, cfg80211 will
> deadlock in the netdev notifier because we're already
> holding rdev->mtx and try to acquire it again to verify
> the scan has been done.
>
> This bug was introduced by my patch
> "cfg80211: check for and abort dangling scan requests".
[...]
> Reported-by: Christian Lamparter <chunkeey@web.de>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
I was bitten by the bug as well and this patch fixed it. Thanks.
Tested-by: Kalle Valo <kalle.valo@iki.fi>
--
Kalle Valo
prev parent reply other threads:[~2009-08-17 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-16 11:32 [PATCH] cfg80211: fix deadlock Johannes Berg
2009-08-16 11:59 ` Christian Lamparter
2009-08-17 10:25 ` [PATCH v2] " Johannes Berg
2009-08-17 15:31 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdkmtq22.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=chunkeey@web.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).