* [PATCH] iwlwifi: pcie: fix a warning / build failure
@ 2021-11-24 1:17 Adam Borowski
2021-11-24 8:12 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Adam Borowski @ 2021-11-24 1:17 UTC (permalink / raw)
To: Luca Coelho, Kalle Valo, Johannes Berg, linux-wireless, netdev
Cc: Adam Borowski
drivers/net/wireless/intel/iwlwifi/pcie/drv.c:
In function ‘iwl_pci_find_dev_info’:
./include/linux/kernel.h:46:25: error: overflow in conversion from
‘long unsigned int’ to ‘int’ changes value from
‘18446744073709551615’ to ‘-1’ [-Werror=overflow]
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
Another option would be to #ifdef away iwl_pci_find_dev_info().
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index c574f041f096..81e8f2fc4982 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -1341,7 +1341,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
{
int i;
- for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
+ for (i = (int)ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i];
if (dev_info->device != (u16)IWL_CFG_ANY &&
--
2.34.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iwlwifi: pcie: fix a warning / build failure
2021-11-24 1:17 [PATCH] iwlwifi: pcie: fix a warning / build failure Adam Borowski
@ 2021-11-24 8:12 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-11-24 8:12 UTC (permalink / raw)
To: Adam Borowski; +Cc: Luca Coelho, Johannes Berg, linux-wireless, netdev
Adam Borowski <kilobyte@angband.pl> writes:
> drivers/net/wireless/intel/iwlwifi/pcie/drv.c:
> In function ‘iwl_pci_find_dev_info’:
> ./include/linux/kernel.h:46:25: error: overflow in conversion from
> ‘long unsigned int’ to ‘int’ changes value from
> ‘18446744073709551615’ to ‘-1’ [-Werror=overflow]
>
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
> Another option would be to #ifdef away iwl_pci_find_dev_info().
>
> drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> index c574f041f096..81e8f2fc4982 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> @@ -1341,7 +1341,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
> {
> int i;
>
> - for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
> + for (i = (int)ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
> const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i];
>
> if (dev_info->device != (u16)IWL_CFG_ANY &&
There's already fix for this:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=fe785f56ad5886c08d1cadd9e8b4e1ff6a1866f6
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-24 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 1:17 [PATCH] iwlwifi: pcie: fix a warning / build failure Adam Borowski
2021-11-24 8:12 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).