From: Kalle Valo <kvalo@codeaurora.org>
To: Pkshih <pkshih@realtek.com>
Cc: "tony0620emma\@gmail.com" <tony0620emma@gmail.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>, Timlee <timlee@realtek.com>,
Kevin Yang <kevin_yang@realtek.com>
Subject: Re: [PATCH 3/4] rtw88: support adaptivity for ETSI/JP DFS region
Date: Tue, 21 Sep 2021 17:47:48 +0300 [thread overview]
Message-ID: <87y27qt27f.fsf@codeaurora.org> (raw)
In-Reply-To: <61a242c186bf453d80820d81e1c48464@realtek.com> (Pkshih's message of "Mon, 30 Aug 2021 06:46:57 +0000")
Pkshih <pkshih@realtek.com> writes:
>> > --- a/drivers/net/wireless/realtek/rtw88/main.c
>> > +++ b/drivers/net/wireless/realtek/rtw88/main.c
>> > @@ -23,6 +23,7 @@ EXPORT_SYMBOL(rtw_disable_lps_deep_mode);
>> > bool rtw_bf_support = true;
>> > unsigned int rtw_debug_mask;
>> > EXPORT_SYMBOL(rtw_debug_mask);
>> > +bool rtw_edcca_enabled = true;
>>
>> You are making rtw_edcca_enabled per driver, should it instead be per
>> device? If something is changed via debugfs the assumption is that the
>> value is per device.
>>
>> For example, let's say you have two rtw88 devices attached on the same
>> system, device A and B. If a user changes edcca via debugfs on device A
>> it will also change the state in device B. Is that the desired
>> functionality? If yes, I think you should add a comment to
>> rtw_edcca_enabled explaining that.
>>
>
> As mentioned in commit message, the debugfs is expected to be used when debugging
> in noisy environment. In that case, we think all rtw88 devices will probably
> be affected. Besides, we believe that turning EDCCA off is a temporary state under
> debugging.
>
> Based on the two points, it seems no need to maintain rtw_edcca_enabled by device,
> so a comment will be added to explain this.
Ok, fair enough.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-09-21 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 6:31 [PATCH 0/4] rtw88: update regulartory mapping and adaptivity Ping-Ke Shih
2021-08-02 6:31 ` [PATCH 1/4] rtw88: upgrade rtw_regulatory mechanism and mapping Ping-Ke Shih
2021-08-02 6:31 ` [PATCH 2/4] rtw88: add regulatory strategy by chip type Ping-Ke Shih
2021-08-29 11:33 ` Kalle Valo
2021-08-30 6:41 ` Pkshih
2021-08-02 6:31 ` [PATCH 3/4] rtw88: support adaptivity for ETSI/JP DFS region Ping-Ke Shih
2021-08-29 11:40 ` Kalle Valo
2021-08-30 6:46 ` Pkshih
2021-09-21 14:47 ` Kalle Valo [this message]
2021-08-02 6:31 ` [PATCH 4/4] rtw88: move adaptivity mechanism to firmware Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y27qt27f.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=kevin_yang@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=timlee@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).