linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "zhengbin \(A\)" <zhengbin13@huawei.com>
Cc: <pkshih@realtek.com>, <linux-wireless@vger.kernel.org>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
Date: Wed, 09 Oct 2019 16:05:15 +0300	[thread overview]
Message-ID: <87y2xuqdbo.fsf@codeaurora.org> (raw)
In-Reply-To: <0135c3c7-a827-941a-1bad-90129c49d0ac@huawei.com> (zhengbin's message of "Wed, 9 Oct 2019 21:01:54 +0800")

"zhengbin (A)" <zhengbin13@huawei.com> writes:

> On 2019/10/9 20:58, Kalle Valo wrote:
>> zhengbin <zhengbin13@huawei.com> writes:
>>
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning:
>>> variable err set but not used [-Wunused-but-set-variable]
>>>
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
>>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>> There's no changelog, why did you resend? Document clearly the changes
>> so that maintainers don't need to guess what has changed:
>
> Failed to apply:
>
> fatal: corrupt patch at line 13
> error: could not build fake ancestor
> Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err'
> Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err'
> The copy of the patch that failed is found in: .git/rebase-apply/patch
>
> So I resend this. 

Ok, thanks. But next time include the changelog automatically and mark
the patch as v2. And read the documentation:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
Kalle Valo

  reply	other threads:[~2019-10-09 13:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09  9:08 [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
2019-10-09 12:58 ` Kalle Valo
2019-10-09 13:01   ` zhengbin (A)
2019-10-09 13:05     ` Kalle Valo [this message]
2019-10-09 13:06       ` zhengbin (A)
2019-10-11  8:53 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2xuqdbo.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).