From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@qti.qualcomm.com>
Cc: Wen Gong <wgong@codeaurora.org>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"ath10k\@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [EXTERNAL] Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature
Date: Tue, 04 Sep 2018 14:43:23 +0300 [thread overview]
Message-ID: <87zhwx7ajo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <b6d8ada015e04738b6b3cee95e485e14@aptaiexm02f.ap.qualcomm.com> (Wen Gong's message of "Tue, 4 Sep 2018 11:18:25 +0000")
Wen Gong <wgong@qti.qualcomm.com> writes:
>> > +enum wmi_nlo_cipher_algorithm {
>> > + WMI_NLO_CIPHER_ALGO_NONE = 0x00,
>> > + WMI_NLO_CIPHER_ALGO_WEP40 = 0x01,
>> > + WMI_NLO_CIPHER_ALGO_TKIP = 0x02,
>> > + WMI_NLO_CIPHER_ALGO_CCMP = 0x04,
>> > + WMI_NLO_CIPHER_ALGO_WEP104 = 0x05,
>> > + WMI_NLO_CIPHER_ALGO_BIP = 0x06,
>> > + WMI_NLO_CIPHER_ALGO_WPA_USE_GROUP = 0x100,
>> > + WMI_NLO_CIPHER_ALGO_RSN_USE_GROUP = 0x100,
>>
>> Two defines with the same value 0x100, is this really correct?
>
> Yes, it is an interface between host driver /firmware.
Yeah, I know it's an interface between the host driver and the firmware
but it does not make any sense and is just confusing. Either of them
should be dropped.
--
Kalle Valo
next prev parent reply other threads:[~2018-09-04 16:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 6:48 [PATCH v3] ath10k: support NET_DETECT WoWLAN feature Wen Gong
2018-09-04 9:15 ` Kalle Valo
2018-09-04 11:18 ` [EXTERNAL] " Wen Gong
2018-09-04 11:43 ` Kalle Valo [this message]
2018-09-05 2:51 ` Wen Gong
2018-10-12 15:37 ` Kalle Valo
2018-10-13 17:18 ` Kalle Valo
2018-11-14 22:59 ` Brian Norris
2019-09-17 16:32 ` Brian Norris
2019-09-18 14:03 ` Kalle Valo
2019-09-20 0:52 ` Brian Norris
2019-09-20 2:55 ` Wen Gong
2019-09-20 7:32 ` Kalle Valo
2019-09-20 9:37 ` Wen Gong
2019-10-03 0:58 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhwx7ajo.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
--cc=wgong@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).