linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: kbuild test robot <lkp@intel.com>
Cc: Felix Fietkau <nbd@nbd.name>,
	kbuild-all@01.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: fix debugfs_simple_attr.cocci warnings
Date: Thu, 07 Dec 2017 15:42:39 +0200	[thread overview]
Message-ID: <87zi6uhcxc.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20171123072723.GA16326@lkp-ne02> (kbuild test robot's message of "Thu, 23 Nov 2017 15:27:23 +0800")

kbuild test robot <lkp@intel.com> writes:

> drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE
>
>  Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
>  for debugfs files.
>
> Semantic patch information:
>  Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
>  imposes some significant overhead as compared to
>  DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
>
> Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e")
> CC: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

I would like to apply this but the From field doesn't match the s-o-b
line. This patch is created automatically, right? I think the best is
that if you modify your script to add this to the beginning of the
commit log:

From: Fengguang Wu <fengguang.wu@intel.com>

That way From and s-o-b match and you can continue to submit it from the
lkp address.

-- 
Kalle Valo

  reply	other threads:[~2017-12-07 13:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 19:35 [PATCH v7 0/3] mt76: add new wireless driver for MediaTek MT76x2 PCIe chips Felix Fietkau
2017-11-20 19:35 ` [PATCH v7 1/3] dt-bindings: net: add mt76 wireless device binding Felix Fietkau
2017-11-20 21:34   ` Rob Herring
2017-11-21  7:08   ` [v7,1/3] " Kalle Valo
     [not found]   ` <20171121070837.AA354607EA@smtp.codeaurora.org>
2017-11-21  8:45     ` Felix Fietkau
2017-11-20 19:35 ` [PATCH v7 2/3] mt76: add common code shared between multiple chipsets Felix Fietkau
2017-11-20 19:35 ` [PATCH v7 3/3] mt76: add driver code for MT76x2e Felix Fietkau
2017-11-23  7:05   ` kbuild test robot
2017-11-23  7:42     ` Kalle Valo
2017-11-23  7:27   ` kbuild test robot
2017-11-23  7:27   ` [PATCH] mt76: fix debugfs_simple_attr.cocci warnings kbuild test robot
2017-12-07 13:42     ` Kalle Valo [this message]
2017-12-08  1:29       ` Fengguang Wu
2017-11-23  7:27   ` [PATCH] mt76: fix returnvar.cocci warnings kbuild test robot
2017-12-07 13:43     ` Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2017-02-02 14:06 [PATCH] mt76: fix debugfs_simple_attr.cocci warnings Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zi6uhcxc.fsf@purkki.adurom.net \
    --to=kvalo@codeaurora.org \
    --cc=kbuild-all@01.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).