From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH V2 1/6] rtlwifi: Change logging level for key change
Date: Tue, 03 Feb 2015 15:01:53 +0200 [thread overview]
Message-ID: <87zj8vw3lq.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <54CBA794.90508@lwfinger.net> (Larry Finger's message of "Fri, 30 Jan 2015 09:47:32 -0600")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 01/26/2015 02:42 PM, Larry Finger wrote:
>> A recent change in key handling included logging of these changes for
>> all debug levels. Such key changes should only be logged when a high
>> level of debugging is enabled.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>> drivers/net/wireless/rtlwifi/cam.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
>> index 3ef870d..6e64792 100644
>> --- a/drivers/net/wireless/rtlwifi/cam.c
>> +++ b/drivers/net/wireless/rtlwifi/cam.c
>> @@ -406,7 +406,7 @@ u8 rtl_cam_get_free_entry(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
>> }
>> }
>> if (found) {
>> - RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG,
>> + RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
>> "key_index=%d,cam_bitmap: 0x%x entry_idx=%d\n",
>> key_index, rtlpriv->sec.cam_bitmap, entry_idx);
>> return entry_idx;
>>
>
> Kalle,
>
> Please include this patch even though the rest of this set should be
> dropped.
I tried to do that but it failed:
Applying: rtlwifi: Change logging level for key change
fatal: sha1 information is lacking or useless (drivers/net/wireless/rtlwifi/cam.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 rtlwifi: Change logging level for key change
I was not even able to find that code from cam.c. Have I missed a patch?
> Once the wifi-BT communications problem is resolved, new versions of
> those will be presented.
Sounds good.
> I'm sorry that my commit message was not as informative as it could
> have been. I was presented with this material that I did not
> understand. One saving grace is that the RTL8812AE hardware is
> apparently rare - I certainly do not have any samples. I'm not sure of
> the value of a 1x1 implementation of 802.11ac, but that may be another
> example of my ignorance.
No worries. But stuff like this is usually best to send as RFC first and
ask people to analyse it before sending it officially.
--
Kalle Valo
next prev parent reply other threads:[~2015-02-03 13:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 20:42 [PATCH 0/6 V2] Some changes for rtlwifi Larry Finger
2015-01-26 20:42 ` [PATCH V2 1/6] rtlwifi: Change logging level for key change Larry Finger
2015-01-30 15:47 ` Larry Finger
2015-02-03 13:01 ` Kalle Valo [this message]
2015-01-26 20:42 ` [PATCH V2 2/6] rtlwifi: btcoexist: Remove typedef statements Larry Finger
2015-01-26 20:42 ` [PATCH V2 3/6] rtlwifi: btcoexist: Add routines for RTL8812AE with single antenna Larry Finger
2015-01-26 20:42 ` [PATCH V2 4/6] rtlwifi: btcoexist: Add routines for RTL8812AE with dual antennae Larry Finger
2015-01-26 20:42 ` [PATCH V2 5/6] rtlwifi: btcoexist: Add routines for RTL8812AE kernel socket communications Larry Finger
2015-01-30 9:19 ` Kalle Valo
2015-01-30 9:57 ` Marcel Holtmann
2015-01-30 15:18 ` Larry Finger
2015-01-30 18:05 ` Marcel Holtmann
2015-02-03 12:29 ` btcoex subsystem Kalle Valo
2015-02-12 20:28 ` Marcel Holtmann
2015-01-26 20:42 ` [PATCH V2 6/6] rtlwifi: btcoexist: Enable new routines for RTL8812AE Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj8vw3lq.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).