linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: allow configure_filter callback to sleep
Date: Mon, 17 Aug 2009 17:24:44 +0300	[thread overview]
Message-ID: <87zl9ytt5f.fsf@litku.valot.fi> (raw)
In-Reply-To: <1250518613.15103.7.camel@johannes.local> (Johannes Berg's message of "Mon\, 17 Aug 2009 16\:16\:53 +0200")

Johannes Berg <johannes@sipsolutions.net> writes:

> Over time, a whole bunch of drivers have come up
> with their own scheme to delay the configure_filter
> operation to a workqueue. To be able to simplify
> things, allow configure_filter to sleep, and add
> a new prepare_multicast callback that drivers that
> need the multicast address list implement. This new
> callback must be atomic, but most drivers either
> don't care or just calculate a hash which can be
> done atomically and then uploaded to the hardware
> non-atomically.
>
> A cursory look suggests that at76c50x-usb,

BTW, at76c50x-usb is broken currently. The change of providing bssid to
the driver only after association broke it. I don't have time to fix it
right now, but I try to find some time next week.

> ar9170, mwl8k (which is actually very broken now), rt2x00, wl1251,
> wl1271 and zd1211 should make use of this new capability.

This will make things a lot easier for wl1251 and wl1271. Thank you for
this.

-- 
Kalle Valo

  reply	other threads:[~2009-08-17 14:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 14:16 [PATCH] mac80211: allow configure_filter callback to sleep Johannes Berg
2009-08-17 14:24 ` Kalle Valo [this message]
2009-08-17 15:00 ` Johannes Berg
2009-08-17 16:06   ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zl9ytt5f.fsf@litku.valot.fi \
    --to=kalle.valo@iki.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).