linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/7] cfg80211: More error messages for key addition failures
Date: Sat, 22 Feb 2020 17:17:44 +0100	[thread overview]
Message-ID: <8a1516685201cc25cdcb8ac0016e0b5f30401f2f.camel@sipsolutions.net> (raw)
In-Reply-To: <20200222132548.20835-1-jouni@codeaurora.org>

On Sat, 2020-02-22 at 15:25 +0200, Jouni Malinen wrote:
> 
> -	if (!err)
> +	if (err)
> +		GENL_SET_ERR_MSG(info, "key not allowed");
> +	if (!err) {
>  		err = rdev_add_key(rdev, dev, key.idx,

[...]

Had to read this twice, but I don't see any reason not to put an else
there? :)

I can fix it up later when I apply it.

Thanks, btw, BIGTK was definitely something we were also looking into
now.

johannes


      parent reply	other threads:[~2020-02-22 16:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-22 13:25 [PATCH 1/7] cfg80211: More error messages for key addition failures Jouni Malinen
2020-02-22 13:25 ` [PATCH 2/7] cfg80211: Support key configuration for Beacon protection (BIGTK) Jouni Malinen
2020-02-22 13:25 ` [PATCH 3/7] mac80211: Support BIGTK configuration for Beacon protection Jouni Malinen
2020-02-22 13:25 ` [PATCH 4/7] mac80211: Update BIP to support Beacon frames Jouni Malinen
2020-02-22 13:25 ` [PATCH 5/7] mac80211: Beacon protection using the new BIGTK (AP) Jouni Malinen
2020-02-22 13:25 ` [PATCH 6/7] mac80211: Beacon protection using the new BIGTK (STA) Jouni Malinen
2020-02-22 13:25 ` [PATCH 7/7] mac80211: Enable Beacon protection Jouni Malinen
2020-02-22 16:17 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a1516685201cc25cdcb8ac0016e0b5f30401f2f.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=jouni@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).