linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Lazar <ailizaro@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
Subject: Re: [PATCH v5 1/2] nl80211: Add support for EDMG channels
Date: Thu, 01 Aug 2019 16:15:35 +0300	[thread overview]
Message-ID: <8a445e39175f1aaf7cc3eaa6c4474619@codeaurora.org> (raw)
In-Reply-To: <4deeee0289e706d5e594d00d987c233fb8fb25b5.camel@sipsolutions.net>

On 2019-07-26 16:29, Johannes Berg wrote:
> Hi Alexei,
> 
> I'm not exactly sure why, but this breaks practically all connectivity
> on 2.4 and 5 GHz channels (at least in hwsim tests).
> 
> Please check and resubmit.

Sorry for this issue, we have run hwsim test through wpa_supplicant and
catch small issue that caused the tests to fail - fix raised.
Can you please share with us how you run the hwsim, you also used the
wpa_supplicant unit tests or some other tool?

> 
> It'd also be good to reformat the commit log a bit, maybe adding
> paragraphs, it's a bit of a "wall of text".

Done.

> 
> Thanks,
> johannes

-- 
Alexei Lazar
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum a
Linux Foundation Collaborative Project

  reply	other threads:[~2019-08-01 13:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 12:46 [PATCH v5 0/2] Add support for new channels on 60GHz band Alexei Avshalom Lazar
2019-07-15 12:46 ` [PATCH v5 1/2] nl80211: Add support for EDMG channels Alexei Avshalom Lazar
2019-07-26 13:29   ` Johannes Berg
2019-08-01 13:15     ` Alexei Lazar [this message]
2019-08-01 13:49       ` Johannes Berg
2019-07-15 12:46 ` [PATCH v5 2/2] wil6210: Add EDMG channel support Alexei Avshalom Lazar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a445e39175f1aaf7cc3eaa6c4474619@codeaurora.org \
    --to=ailizaro@codeaurora.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wil6210@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).