From: Larry Finger <Larry.Finger@lwfinger.net>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
Ping-Ke Shih <pkshih@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out
Date: Sat, 5 Jan 2019 10:37:01 -0600 [thread overview]
Message-ID: <8a594059-fdeb-9abf-24a3-c44cb429fea3@lwfinger.net> (raw)
In-Reply-To: <DB7PR07MB53539F1836CE716739F2409AE48F0@DB7PR07MB5353.eurprd07.prod.outlook.com>
On 1/5/19 10:30 AM, Bernd Edlinger wrote:
> On 1/5/19 5:13 PM, Larry Finger wrote:
>>> but this works:
>>>
>>> modprobe rtl8723ae debug_mask=0xFFFFFFFF debug_level=5 swlps=1 fwlps=0
>>
>> Yes, I think that is a better thing to do now. If and when Realtek finds a firmware bug, and when the new firmware is readily available, then there will not be a lot of code to reinstall.
>>
>
> Okay, my assumption of how the firmware bug "works" is this:
>
> Once the firmware enters power save mode, it will deliver exactly one (or maybe two)
> Rx interrupts. If one of those triggers the driver to leave the power save mode again,
> the firmware continues to work.
> If those are only beacons, they won't leave the power save mode. Then the firmware
> will usually not recover.
> Since prior to commit 873ffe154ae0 ("rtlwifi: Fix logic error in enter/exit power-save mode")
> the power save mode was only activated when there _is_ busy traffic, the next
> packet did usually wake the firmware, rarely it did freeze however.
> Other things like changing the cck_packet_detection_threshold or refresh_rate_adaptive_mask
> can also kick the firmware back to life.
>
> Hope this helps to track down the root cause of this bug.
As I know nothing of the firmware, that is outside my expertise, but that
observation should be of great help to PK Shih, and his colleagues at Realtek.
Larry
prev parent reply other threads:[~2019-01-05 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 12:48 [PATCH 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out Bernd Edlinger
2019-01-05 2:44 ` Larry Finger
2019-01-05 11:31 ` Bernd Edlinger
2019-01-05 16:13 ` Larry Finger
2019-01-05 16:30 ` Bernd Edlinger
2019-01-05 16:37 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a594059-fdeb-9abf-24a3-c44cb429fea3@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bernd.edlinger@hotmail.de \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).