From: Tamizh chelvam <tamizhr@codeaurora.org>
To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc: ath10k@lists.infradead.org, johannes@sipsolutions.net,
linux-wireless@vger.kernel.org,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Subject: Re: [PATCH 2/4] nl80211: Add netlink attribute for AMPDU aggregation enable/disable
Date: Thu, 08 Nov 2018 17:58:45 +0530 [thread overview]
Message-ID: <8a8444300c7fc772b0fb219e08c88498@codeaurora.org> (raw)
In-Reply-To: <20181106102051.7erib7owjms64knl@bars>
Hi Sergey,
> Hello Tamizh,
>
>> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>
>> ---
>> include/net/cfg80211.h | 6 ++++++
>> include/uapi/linux/nl80211.h | 21 +++++++++++++++++++++
>> net/wireless/nl80211.c | 17 +++++++++++++++++
>> net/wireless/rdev-ops.h | 15 +++++++++++++++
>> net/wireless/trace.h | 23 +++++++++++++++++++++++
>> 5 files changed, 82 insertions(+)
> ...
>
>> diff --git a/include/uapi/linux/nl80211.h
>> b/include/uapi/linux/nl80211.h
>> index 9dfcf0a6..7ba0fb7 100644
>> --- a/include/uapi/linux/nl80211.h
>> +++ b/include/uapi/linux/nl80211.h
>> @@ -4449,6 +4449,20 @@ enum nl80211_ps_state {
>> * the max value should be advertised by the driver through
>> * max_data_retry_count. when this attribute is not present, the
>> driver
>> * would use the default configuration.
>> + * @NL80211_ATTR_TID_AMPDU_AGGR_CTRL: Enable/Disable aggregation for
>> the TID
>> + * specified in %%NL80211_ATTR_TID. Its type is u8, if the peer
>> MAC address
>> + * is passed in %NL80211_ATTR_MAC, the aggregation configuration
>> is applied
>> + * to the data frame for the tid to that connected station.
>> + * Station specific aggregation configuration is valid only for
>> STA's
>> + * current connection. i.e. the configuration will be reset to
>> default when
>> + * the station connects back after disconnection/roaming.
>> + * when user-space does not include %NL80211_ATTR_MAC, this
>> configuration
>> + * should be treated as per-netdev configuration. This
>> configuration will
>> + * be cleared when the interface goes down and on the
>> disconnection from a
>> + * BSS. Driver supporting this feature should advertise
>> + * NL80211_EXT_FEATURE_PER_STA_AMPDU_AGGR_CTRL and supporting per
>> station
>
> typo: should be NL80211_EXT_FEATURE_PER_TID_AMPDU_AGGR_CTRL
Sure, I'll update in the next version.
>
>> + * aggregation configuration should advertise
>> + * NL80211_EXT_FEATURE_PER_STA_AMPDU_AGGR_CTRL.
>> */
>
> Regards,
> Sergey
Thanks,
Tamizh.
next prev parent reply other threads:[~2018-11-08 12:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 17:55 [PATCH 0/4] cfg80211/mac80211: Add support for TID specific configuration Tamizh chelvam
2018-10-22 17:55 ` [PATCH 1/4] New netlink command " Tamizh chelvam
2018-11-06 10:16 ` Sergey Matyukevich
2018-11-08 17:29 ` Tamizh chelvam
2018-11-09 9:47 ` Sergey Matyukevich
2018-11-06 11:31 ` Johannes Berg
2018-11-07 14:05 ` Sergey Matyukevich
2018-11-08 17:47 ` Tamizh chelvam
2018-11-09 9:40 ` Sergey Matyukevich
2018-11-09 12:24 ` Johannes Berg
2018-11-13 6:46 ` Tamizh chelvam
2018-11-09 11:37 ` Johannes Berg
2018-10-22 17:55 ` [PATCH 2/4] nl80211: Add netlink attribute for AMPDU aggregation enable/disable Tamizh chelvam
2018-11-06 10:21 ` Sergey Matyukevich
2018-11-08 12:28 ` Tamizh chelvam [this message]
2018-10-22 17:55 ` [PATCH 3/4] mac80211: Add api to support configuring TID specific configuration Tamizh chelvam
2018-11-06 10:33 ` Sergey Matyukevich
2018-11-08 12:42 ` Tamizh chelvam
2018-11-07 23:55 ` Igor Mitsyanko
2018-10-22 17:55 ` [PATCH 4/4] ath10k: Add support to configure " Tamizh chelvam
2018-11-09 9:26 ` Sergey Matyukevich
2018-11-05 20:43 ` [PATCH 0/4] cfg80211/mac80211: Add support for " Johannes Berg
2018-11-06 10:45 ` Sergey Matyukevich
2018-11-06 11:28 ` Johannes Berg
2018-11-06 12:17 ` Sergey Matyukevich
2018-11-08 0:55 ` Igor Mitsyanko
2018-11-08 16:31 ` Ben Greear
2019-02-13 19:01 ` Sergey Matyukevich
[not found] ` <a7d97b692da245a8b85769d7766ceba7@aphydexm01f.ap.qualcomm.com>
2019-02-14 7:14 ` Tamizh chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a8444300c7fc772b0fb219e08c88498@codeaurora.org \
--to=tamizhr@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sergey.matyukevich.os@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).