Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
* [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing
@ 2020-06-25 16:52 Wolfram Sang
  2020-07-26 15:26 ` Wolfram Sang
  2020-08-02 15:08 ` Kalle Valo
  0 siblings, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-06-25 16:52 UTC (permalink / raw)
  To: linux-wireless
  Cc: Wolfram Sang, Johannes Berg, Emmanuel Grumbach, Luca Coelho,
	Intel Linux Wireless, Kalle Valo, David S. Miller,
	Jakub Kicinski, netdev, linux-kernel

Missing this firmware is not fatal, my wifi card still works. Even more,
I couldn't find any documentation what it is or where to get it. So, I
don't think the users should be notified if it is missing. If you browse
the net, you see the message is present is in quite some logs. Better
remove it.

Signed-off-by: Wolfram Sang <wsa@kernel.org>
---

This is only build tested because I wanted to get your opinions first. I
couldn't find any explanation about yoyo, so I am entering unknown
territory here.

 drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
index 7987a288917b..f180db2936e3 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
@@ -468,7 +468,7 @@ void iwl_dbg_tlv_load_bin(struct device *dev, struct iwl_trans *trans)
 	if (!iwlwifi_mod_params.enable_ini)
 		return;
 
-	res = request_firmware(&fw, "iwl-debug-yoyo.bin", dev);
+	res = firmware_request_nowarn(&fw, "iwl-debug-yoyo.bin", dev);
 	if (res)
 		return;
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing
  2020-06-25 16:52 [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing Wolfram Sang
@ 2020-07-26 15:26 ` Wolfram Sang
  2020-07-26 18:11   ` Kalle Valo
  2020-08-02 15:08 ` Kalle Valo
  1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2020-07-26 15:26 UTC (permalink / raw)
  To: linux-wireless
  Cc: Johannes Berg, Emmanuel Grumbach, Luca Coelho,
	Intel Linux Wireless, Kalle Valo, David S. Miller,
	Jakub Kicinski, netdev, linux-kernel


[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> Missing this firmware is not fatal, my wifi card still works. Even more,
> I couldn't find any documentation what it is or where to get it. So, I
> don't think the users should be notified if it is missing. If you browse
> the net, you see the message is present is in quite some logs. Better
> remove it.
> 
> Signed-off-by: Wolfram Sang <wsa@kernel.org>
> ---

Any input on this? Or people I should add to CC?

> 
> This is only build tested because I wanted to get your opinions first. I
> couldn't find any explanation about yoyo, so I am entering unknown
> territory here.
> 
>  drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> index 7987a288917b..f180db2936e3 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
> @@ -468,7 +468,7 @@ void iwl_dbg_tlv_load_bin(struct device *dev, struct iwl_trans *trans)
>  	if (!iwlwifi_mod_params.enable_ini)
>  		return;
>  
> -	res = request_firmware(&fw, "iwl-debug-yoyo.bin", dev);
> +	res = firmware_request_nowarn(&fw, "iwl-debug-yoyo.bin", dev);
>  	if (res)
>  		return;
>  
> -- 
> 2.20.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing
  2020-07-26 15:26 ` Wolfram Sang
@ 2020-07-26 18:11   ` Kalle Valo
  2020-07-26 18:24     ` Wolfram Sang
  2020-07-27  6:21     ` Luciano Coelho
  0 siblings, 2 replies; 6+ messages in thread
From: Kalle Valo @ 2020-07-26 18:11 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-wireless, Johannes Berg, Emmanuel Grumbach, Luca Coelho,
	Intel Linux Wireless, David S. Miller, Jakub Kicinski, netdev,
	linux-kernel

Wolfram Sang <wsa@kernel.org> writes:

> On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
>> Missing this firmware is not fatal, my wifi card still works. Even more,
>> I couldn't find any documentation what it is or where to get it. So, I
>> don't think the users should be notified if it is missing. If you browse
>> the net, you see the message is present is in quite some logs. Better
>> remove it.
>> 
>> Signed-off-by: Wolfram Sang <wsa@kernel.org>
>> ---
>
> Any input on this? Or people I should add to CC?

This was discussed on another thread:

https://lkml.kernel.org/r/87mu3magfp.fsf@tynnyri.adurom.net

Unless Intel folks object I'm planning to take this to
wireless-drivers-next.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing
  2020-07-26 18:11   ` Kalle Valo
@ 2020-07-26 18:24     ` Wolfram Sang
  2020-07-27  6:21     ` Luciano Coelho
  1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-07-26 18:24 UTC (permalink / raw)
  To: Kalle Valo
  Cc: linux-wireless, Johannes Berg, Emmanuel Grumbach, Luca Coelho,
	Intel Linux Wireless, David S. Miller, Jakub Kicinski, netdev,
	linux-kernel


[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

On Sun, Jul 26, 2020 at 09:11:25PM +0300, Kalle Valo wrote:
> Wolfram Sang <wsa@kernel.org> writes:
> 
> > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> >> Missing this firmware is not fatal, my wifi card still works. Even more,
> >> I couldn't find any documentation what it is or where to get it. So, I
> >> don't think the users should be notified if it is missing. If you browse
> >> the net, you see the message is present is in quite some logs. Better
> >> remove it.
> >> 
> >> Signed-off-by: Wolfram Sang <wsa@kernel.org>
> >> ---
> >
> > Any input on this? Or people I should add to CC?
> 
> This was discussed on another thread:
> 
> https://lkml.kernel.org/r/87mu3magfp.fsf@tynnyri.adurom.net
> 
> Unless Intel folks object I'm planning to take this to
> wireless-drivers-next.

Cool, thanks for the heads up!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing
  2020-07-26 18:11   ` Kalle Valo
  2020-07-26 18:24     ` Wolfram Sang
@ 2020-07-27  6:21     ` Luciano Coelho
  1 sibling, 0 replies; 6+ messages in thread
From: Luciano Coelho @ 2020-07-27  6:21 UTC (permalink / raw)
  To: Kalle Valo, Wolfram Sang
  Cc: linux-wireless, Johannes Berg, Emmanuel Grumbach,
	Intel Linux Wireless, David S. Miller, Jakub Kicinski, netdev,
	linux-kernel

On Sun, 2020-07-26 at 21:11 +0300, Kalle Valo wrote:
> Wolfram Sang <wsa@kernel.org> writes:
> 
> > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> > > Missing this firmware is not fatal, my wifi card still works. Even more,
> > > I couldn't find any documentation what it is or where to get it. So, I
> > > don't think the users should be notified if it is missing. If you browse
> > > the net, you see the message is present is in quite some logs. Better
> > > remove it.
> > > 
> > > Signed-off-by: Wolfram Sang <wsa@kernel.org>
> > > ---
> > 
> > Any input on this? Or people I should add to CC?
> 
> This was discussed on another thread:
> 
> https://lkml.kernel.org/r/87mu3magfp.fsf@tynnyri.adurom.net
> 
> Unless Intel folks object I'm planning to take this to
> wireless-drivers-next.

Yes, please, just go ahead and take it.  I have the same change in our
internal tree, but I didn't have the time to send it out due to my
vacations (from which I'm now back).

--
Cheers,
Luca.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing
  2020-06-25 16:52 [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing Wolfram Sang
  2020-07-26 15:26 ` Wolfram Sang
@ 2020-08-02 15:08 ` Kalle Valo
  1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-08-02 15:08 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-wireless, Wolfram Sang, Johannes Berg, Emmanuel Grumbach,
	Luca Coelho, Intel Linux Wireless, David S. Miller,
	Jakub Kicinski, netdev, linux-kernel

Wolfram Sang <wsa@kernel.org> wrote:

> Missing this firmware is not fatal, my wifi card still works. Even more,
> I couldn't find any documentation what it is or where to get it. So, I
> don't think the users should be notified if it is missing. If you browse
> the net, you see the message is present is in quite some logs. Better
> remove it.
> 
> Signed-off-by: Wolfram Sang <wsa@kernel.org>

Patch applied to wireless-drivers-next.git, thanks.

3f4600de8c93 iwlwifi: yoyo: don't print failure if debug firmware is missing

-- 
https://patchwork.kernel.org/patch/11625759/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-25 16:52 [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing Wolfram Sang
2020-07-26 15:26 ` Wolfram Sang
2020-07-26 18:11   ` Kalle Valo
2020-07-26 18:24     ` Wolfram Sang
2020-07-27  6:21     ` Luciano Coelho
2020-08-02 15:08 ` Kalle Valo

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git