From: Kirill Buksha <kirbuk200@gmail.com>
To: Michael Walle <mwalle@kernel.org>, Ajay.Kathat@microchip.com
Cc: Claudiu.Beznea@microchip.com, linux-wireless@vger.kernel.org,
kvalo@kernel.org
Subject: Re: wilc1000 kernel crash
Date: Mon, 3 Apr 2023 16:24:11 +0200 [thread overview]
Message-ID: <8d6316ef-fd66-0b18-ca5b-bb945ebc5370@gmail.com> (raw)
In-Reply-To: <20221216101842.jjz3glyotqbbqlk4@0002.3ffe.de>
On 16.12.22. 11:18, Michael Walle wrote:
> Hi,
>
> On 22/12/09 02:14, Ajay.Kathat@microchip.com wrote:
>> No progress yet. I tried to simulate the condition a few times but was
>> unable to see the exact failure in my setup so I need to try more.
> Shouldn't it also be possible to see the issue by code reading? I've
> provided the call tree in my previous mail and my concerns regarding
> the locking. Either I'm missing something there or there is no
> locking between these threads which could cause this issue.
>
>> For the other "FW not responding" continuous logs, I got some clue.
>> Probably, will try to send that patch first.
> Ok, let me know if you have some patches, I'm happy to test them.
>
> -michael
>
>
Hello,
I faced the same kernel oops issue. After analyzing my logs and brief
debugging, I agree with Mikhail: the problem seems to be accessing the
scan_result pointer after it has been nulled.
Regarding the solution: if there is a race between two threads (as
Michael described earlier), then I think that the locking mechanism will
be the most reliable solution. We ran into problems during
deinitialization, but driver contains two more places
(handle_scan_done() and wilc_disconnect() functions in wilc1000/hif.c),
where scan_result is set to NULL.
I use NetworkManager to manage networks and I have experienced the same
failure multiple times when switching from one WiFi network to another.
Keep in mind that switching between networks calls wilc_disconnect() and
wilc_deinit() functions and it is not yet clear which one is causing a
core dump. I think it's worth at least taking a look at these areas of
the code. What do you think?
Best regards,
Kirill Buksha.
next prev parent reply other threads:[~2023-04-03 14:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 13:54 wilc1000 kernel crash Michael Walle
2022-10-25 20:26 ` Ajay.Kathat
2022-10-26 8:54 ` Michael Walle
2022-12-09 12:03 ` Michael Walle
2022-12-09 14:14 ` Ajay.Kathat
2022-12-16 10:18 ` Michael Walle
2023-04-03 14:24 ` Kirill Buksha [this message]
2023-04-04 1:30 ` Ajay.Kathat
2023-04-04 16:20 ` Kirill Buksha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d6316ef-fd66-0b18-ca5b-bb945ebc5370@gmail.com \
--to=kirbuk200@gmail.com \
--cc=Ajay.Kathat@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mwalle@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).