From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6868C433E0 for ; Thu, 30 Jul 2020 14:28:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6F8520578 for ; Thu, 30 Jul 2020 14:28:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726794AbgG3O2R (ORCPT ); Thu, 30 Jul 2020 10:28:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbgG3O2R (ORCPT ); Thu, 30 Jul 2020 10:28:17 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB49AC061574 for ; Thu, 30 Jul 2020 07:28:16 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) (envelope-from ) id 1k19XZ-00DZv8-7x; Thu, 30 Jul 2020 16:28:13 +0200 Message-ID: <903ec27f7423574f644312c701ed45fdafdb7ca6.camel@sipsolutions.net> Subject: Re: [PATCH] mac80211: Send deauth to STA's upon AP stop From: Johannes Berg To: Shay Bar , Ben Greear Cc: "linux-wireless@vger.kernel.org" Date: Thu, 30 Jul 2020 16:28:12 +0200 In-Reply-To: References: <20200618093609.16514-1-shay.bar@celeno.com> <2a7b33ace030fdeda96e60b2abd6c70a11f426e0.camel@sipsolutions.net> <54236bdd708c53ec2f2a776bb3badcd77c7fecc6.camel@sipsolutions.net> <6da8757ac90a4d34ed1bdc7c84b40aac06c01af9.camel@sipsolutions.net> <2a607392179a76f0f6fc3cef2e6e141f25dc0254.camel@sipsolutions.net> <90ea9478-a42e-be89-0ee1-9e05c2ef8cc9@celeno.com> <5bee074dbf19ab71e3cdc90769dbec0c8ada5274.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4 (3.36.4-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2020-07-30 at 14:23 +0000, Shay Bar wrote: > On 30/07/2020 17:00, Johannes Berg wrote: > > External Email > > > > > > On Thu, 2020-06-25 at 13:29 +0300, Shay Bar wrote: > > > On 25/06/2020 12:51, Johannes Berg wrote: > > > > External Email > > > > > > > > > > > > On Sun, 2020-06-21 at 10:12 +0000, Shay Bar wrote: > > > > > Hi Johannes and Ben, > > > > > > > > > > To conclude this thread, hostapd doesn’t send any deauth/disassoc > > > > > upon AP stop (when hostapd is killed _or_ when "ifconfig down" the > > > > > AP interface). > > > > Right. I'm sort of suggesting you just shouldn't be doing this, and it > > > > doesn't seem like most people actually do, otherwise we'd have seen this > > > > issue before? > > > > > > > I shouldn't kill hostapd? Isn't this a very basic action? > > > What is the alternative for stopping the AP? > > I guess I would say to use hostapd_cli first to "disable" the > > interfaces? > > Indeed, using hostapd_cli "DISABLE" will call > hostapd_flush_old_stations() that will send broadcast deauth. Ah. > The problem is (mentioned before) that some stations (e.g. Samsung S8) > ignore this broadcast (while it will not ignore unicast > deauth/disassoc). Right, you mentioned that. I guess you could work around by disabling all stations separately, but ... not really a great solution either. Perhaps we should fix that at the hostapd level? Not really sure how much trouble we should go to for bad stations though. I mean, it's not like they should be ignoring that. Maybe they just miss it due to super aggressive powersave, and we should send it a few times? johannes