linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wifi: cfg80211/mac80211: add support for channel switch with MLO
Date: Tue, 14 Feb 2023 13:50:17 +0100	[thread overview]
Message-ID: <92344e56e895b18a33ff6d9eed2a2b58e6d92180.camel@sipsolutions.net> (raw)
In-Reply-To: <20230118151604.1278-2-quic_adisi@quicinc.com>

On Wed, 2023-01-18 at 20:46 +0530, Aditya Kumar Singh wrote:
> +++ b/net/mac80211/cfg.c
> @@ -1488,6 +1488,13 @@ static int ieee80211_stop_ap(struct wiphy *wiphy, struct net_device *dev,
>  
>  	mutex_unlock(&local->mtx);
>  
> +	/* The below work requires sdata lock which we have already acquired
> +	 * here. But before that, it will check whether link_conf->csa_active
> +	 * is true, which we have made false above. Hence, it will not proceed
> +	 * to acquire the sdata lock and deadlock will be avoided.
> +	 */

This is obviously wrong.

I know the locking here is hard and that we may need to make some bigger
changes to support cancelling these work items properly, but this
doesn't address it at all.

johannes


  parent reply	other threads:[~2023-02-14 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 15:16 [PATCH 0/2] wifi: cfg80211/mac80211: add link_id handling in channel switch during Multi-Link Operation Aditya Kumar Singh
2023-01-18 15:16 ` [PATCH 1/2] wifi: cfg80211/mac80211: add support for channel switch with MLO Aditya Kumar Singh
2023-01-19  6:07   ` kernel test robot
2023-02-14 12:50   ` Johannes Berg [this message]
2023-01-18 15:16 ` [PATCH 2/2] wifi: mac80211: update beacon counters per link basis Aditya Kumar Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92344e56e895b18a33ff6d9eed2a2b58e6d92180.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_adisi@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).