From: Markus Elfring <Markus.Elfring@web.de>
To: Wang Yufen <wangyufen@huawei.com>,
brcm80211-dev-list@cypress.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Franky Lin <franky.lin@broadcom.com>,
Jakub Kicinski <kuba@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Wright Feng <wright.feng@cypress.com>
Subject: Re: [PATCH] ath11k: Fix memory leak in ath11k_qmi_init_service()
Date: Mon, 20 Jul 2020 13:07:53 +0200 [thread overview]
Message-ID: <9379ef46-5931-5542-c424-916bb8476a92@web.de> (raw)
> When qmi_add_lookup fail, we should destroy the workqueue
Can the following wording variant be nicer for the change description?
Destroy the work queue object in an if branch
after a call of the function “qmi_add_lookup” failed.
Regards,
Markus
reply other threads:[~2020-07-20 11:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9379ef46-5931-5542-c424-916bb8476a92@web.de \
--to=markus.elfring@web.de \
--cc=brcm80211-dev-list@cypress.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangyufen@huawei.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).