linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Markus Theil <markus.theil@tu-ilmenau.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/4] Updates for rfkill
Date: Thu, 21 Jan 2021 13:24:20 +0100	[thread overview]
Message-ID: <9406a5833f2bd6a15bf314717b7ac21952f11f24.camel@sipsolutions.net> (raw)
In-Reply-To: <20210116125146.31932-1-markus.theil@tu-ilmenau.de>

Hi Markus,

Thanks for the patches!

I separately committed a fix for the buffering=0 issue, just so it's
separate and not part of the other changes.

>   rfkill.py: migrate to python3

Applied, but I made some cleanups.

>   rfkill: update rfkill.h
>   rfkill: support hard block reason in python code
>   rfkill: support hard block reason in C code

This is broken, unfortunately. Updating rfkill.h as is causes issues
because we read more data than we are willing to accept, which you've
fixed up in the support for hard block reasons patch. Seems that should
partially be in the original patch - e.g. checking "size >= V1" instead
of "size == V1".

Additionally, the hard block reasons in C patch is wrong because if the
read was short, the field is not initialized. Need to clear the event to
zeroes before reading it, or at least at the beginnning (I guess we can
assume the kernel will not change size between two reads).

The python patch I applied with some fixups.

johannes


      parent reply	other threads:[~2021-01-21 12:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-16 12:51 [PATCH 0/4] Updates for rfkill Markus Theil
2021-01-16 12:51 ` [PATCH 1/4] rfkill.py: migrate to python3 Markus Theil
2021-01-16 12:51 ` [PATCH 2/4] rfkill: update rfkill.h Markus Theil
2021-01-16 12:51 ` [PATCH 3/4] rfkill: support hard block reason in python code Markus Theil
2021-01-16 12:51 ` [PATCH 4/4] rfkill: support hard block reason in C code Markus Theil
2021-01-21 12:24 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9406a5833f2bd6a15bf314717b7ac21952f11f24.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=markus.theil@tu-ilmenau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).