From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC7D7C433E4 for ; Tue, 28 Jul 2020 00:03:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6AC120729 for ; Tue, 28 Jul 2020 00:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726887AbgG1ADU (ORCPT ); Mon, 27 Jul 2020 20:03:20 -0400 Received: from smtprelay0237.hostedemail.com ([216.40.44.237]:35802 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726171AbgG1ADU (ORCPT ); Mon, 27 Jul 2020 20:03:20 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 0EE3F18225DF5; Tue, 28 Jul 2020 00:03:19 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: owner27_5f0264426f65 X-Filterd-Recvd-Size: 2596 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 28 Jul 2020 00:03:17 +0000 (UTC) Message-ID: <940c318b59c3c3e945c80216699299d051f8b4c5.camel@perches.com> Subject: Re: [PATCH][next] ath11k: Use fallthrough pseudo-keyword From: Joe Perches To: Julian Calaby Cc: "Gustavo A. R. Silva" , Kalle Valo , "David S. Miller" , Jakub Kicinski , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, LKML Date: Mon, 27 Jul 2020 17:03:16 -0700 In-Reply-To: References: <20200727194415.GA1275@embeddedor> <70ed74d65b5909615c7a9430f3479695465d3b1d.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2020-07-28 at 09:44 +1000, Julian Calaby wrote: > Hi Joe, > > On Tue, Jul 28, 2020 at 5:48 AM Joe Perches wrote: > > On Mon, 2020-07-27 at 14:44 -0500, Gustavo A. R. Silva wrote: > > > Replace the existing /* fall through */ comments and its variants with > > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > > > fall-through markings when it is the case. > > [] > > > diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/ath/ath11k/dp.c > > [] > > > @@ -159,7 +159,7 @@ int ath11k_dp_srng_setup(struct ath11k_base *ab, struct dp_srng *ring, > > > break; > > > } > > > /* follow through when ring_num >= 3 */ > > > - /* fall through */ > > > + fallthrough; > > > > Likely the /* follow through ... */ comment can be deleted too > > If the "when ring_num >= 3" comment is needed, how should this get > formatted? Maybe something like: > > fallthrough; /* when ring_num >= 3 */ Likely, or just removed as the test above is fairly clear Existing code: case HAL_WBM2SW_RELEASE: if (ring_num < 3) { params.intr_batch_cntr_thres_entries = HAL_SRNG_INT_BATCH_THRESHOLD_TX; params.intr_timer_thres_us = HAL_SRNG_INT_TIMER_THRESHOLD_TX; break; } /* follow through when ring_num >= 3 */ /* fall through */ case HAL_REO_EXCEPTION: