From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "Greenman, Gregory" <gregory.greenman@intel.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"arnd@kernel.org" <arnd@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH net-next] iwlwifi: fix old-style-declaration warning
Date: Tue, 23 Mar 2021 08:04:35 +0000 [thread overview]
Message-ID: <94eedcd0501ba64cfa17fc852dd4f22950a8c435.camel@intel.com> (raw)
In-Reply-To: <20210322215124.1078478-1-arnd@kernel.org>
On Mon, 2021-03-22 at 22:51 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The correct order is 'static const', not 'const static', as seen from
> make W=1:
>
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
>
> Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks, Arnd! But I just applied the patch Wei Yongjun submitted, so
we'll go with that one.
--
Cheers,
Luca.
prev parent reply other threads:[~2021-03-23 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 21:51 [PATCH net-next] iwlwifi: fix old-style-declaration warning Arnd Bergmann
2021-03-23 8:04 ` Coelho, Luciano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94eedcd0501ba64cfa17fc852dd4f22950a8c435.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=gregory.greenman@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).