* [PATCH -next] brcmfmac: make non-global functions static
@ 2020-05-08 1:32 Chen Zhou
2020-05-08 13:31 ` Wright Feng
2020-05-12 8:52 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Chen Zhou @ 2020-05-08 1:32 UTC (permalink / raw)
To: kvalo
Cc: arend.vanspriel, franky.lin, hante.meuleman, chi-hsien.lin,
wright.feng, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev, linux-kernel, chenzhou10
Fix sparse warning:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2206:5:
warning: symbol 'brcmf_p2p_get_conn_idx' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index e32c24a2670d..2a2440031357 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2203,7 +2203,7 @@ static struct wireless_dev *brcmf_p2p_create_p2pdev(struct brcmf_p2p_info *p2p,
return ERR_PTR(err);
}
-int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
+static int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
{
int i;
struct brcmf_if *ifp = netdev_priv(cfg_to_ndev(cfg));
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] brcmfmac: make non-global functions static
2020-05-08 1:32 [PATCH -next] brcmfmac: make non-global functions static Chen Zhou
@ 2020-05-08 13:31 ` Wright Feng
2020-05-12 8:52 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Wright Feng @ 2020-05-08 13:31 UTC (permalink / raw)
To: Chen Zhou, kvalo
Cc: arend.vanspriel, franky.lin, hante.meuleman, chi-hsien.lin,
linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list,
netdev, linux-kernel
Chen Zhou 於 5/8/2020 9:32 AM 寫道:
> Fix sparse warning:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2206:5:
> warning: symbol 'brcmf_p2p_get_conn_idx' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Reviewed-by: Wright Feng <wright.feng@cypress.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> index e32c24a2670d..2a2440031357 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> @@ -2203,7 +2203,7 @@ static struct wireless_dev *brcmf_p2p_create_p2pdev(struct brcmf_p2p_info *p2p,
> return ERR_PTR(err);
> }
>
> -int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
> +static int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
> {
> int i;
> struct brcmf_if *ifp = netdev_priv(cfg_to_ndev(cfg));
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] brcmfmac: make non-global functions static
2020-05-08 1:32 [PATCH -next] brcmfmac: make non-global functions static Chen Zhou
2020-05-08 13:31 ` Wright Feng
@ 2020-05-12 8:52 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-05-12 8:52 UTC (permalink / raw)
To: Chen Zhou
Cc: arend.vanspriel, franky.lin, hante.meuleman, chi-hsien.lin,
wright.feng, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev, linux-kernel, chenzhou10
Chen Zhou <chenzhou10@huawei.com> wrote:
> Fix sparse warning:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2206:5:
> warning: symbol 'brcmf_p2p_get_conn_idx' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> Reviewed-by: Wright Feng <wright.feng@cypress.com>
Patch applied to wireless-drivers-next.git, thanks.
7294ee6f5642 brcmfmac: make non-global functions static
--
https://patchwork.kernel.org/patch/11535195/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-12 8:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 1:32 [PATCH -next] brcmfmac: make non-global functions static Chen Zhou
2020-05-08 13:31 ` Wright Feng
2020-05-12 8:52 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).