From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
Denis Kenzior <denkenz@gmail.com>, Jouni Malinen <j@w1.fi>,
Eric Blau <eblau@eblau.com>
Cc: hostap@lists.infradead.org,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: Kernel oops / WiFi connection failure with wpa_supplicant 2.7
Date: Tue, 15 Jan 2019 14:00:21 +0100 [thread overview]
Message-ID: <9a3f1cf7577caa808e42092c5fc69c54bf3abe36.camel@sipsolutions.net> (raw)
In-Reply-To: <d5599cf9-5fb4-a68d-dfd9-0d10a6758ae2@broadcom.com> (sfid-20190115_000428_971002_08CD2B9E)
> > Maybe this is a question for Johannes as well, but define 'user-space
> > applications'? If that includes wpa_s, wasn't the rule of thumb broken
> > with that commit?
>
> In my previous reply I wanted to add that it would be hard to proof that
> no user-space applications are using the API. Not sure exactly when
> things were added in wpa_s, but I suspect it was
> post-commit-503c1fb98ba3 so it did not have support for the user-space
> API before the commit.
I don't know about this really.
My thought at the time likely was that if there's no driver implementing
it, no userspace could've existed? Or maybe that just wasn't true, and I
got confused?
In any case, it certainly wasn't an intentional API break.
> > > > - What happens if userspace does send an EAPoL-Start in the middle of
> > > > an offloaded 4-way handshake?
> > >
> > > Probably those would be dropped.
> > >
> >
> > I would love to have something more definitive than 'Probably', and it
> > might be worth mentioning this hint in the documentation somewhere.
>
> I was hesitant to use that word, but decided to do so simply because I
> can not speak for every driver and even for the brcmfmac driver that I
> maintain I will need to look into the firmware to be sure. I agree that
> a remark of that possibility is worth adding.
I don't really know if we should really cover all possible error
scenarios like that?
johannes
next prev parent reply other threads:[~2019-01-15 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADU241PtPeiTQWHwb=uF6Ohuua_asOwCarCAKVC8jdVVNAsByA@mail.gmail.com>
[not found] ` <20190103154921.GA25015@w1.fi>
2019-01-05 19:44 ` Kernel oops / WiFi connection failure with wpa_supplicant 2.7 Arend Van Spriel
2019-01-08 17:44 ` Denis Kenzior
2019-01-14 20:12 ` Arend Van Spriel
2019-01-14 21:18 ` Denis Kenzior
2019-01-14 23:04 ` Arend Van Spriel
2019-01-15 13:00 ` Johannes Berg [this message]
2019-01-15 15:55 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a3f1cf7577caa808e42092c5fc69c54bf3abe36.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=denkenz@gmail.com \
--cc=eblau@eblau.com \
--cc=hostap@lists.infradead.org \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).