linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>, <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: mac80211_hwsim: set link ID information during Rx
Date: Wed, 13 Mar 2024 10:25:30 -0700	[thread overview]
Message-ID: <9a8cebda-c627-4876-b5e7-9edbad72ab1a@quicinc.com> (raw)
In-Reply-To: <20240313145402.456514-1-quic_adisi@quicinc.com>

On 3/13/2024 7:54 AM, Aditya Kumar Singh wrote:
> Currently link ID information is not passed to mac80211 via Rx status by
> mac80211_hwsim. This leads to packet getting dropped in function
> __ieee80211_rx_handle_packet since it expects the link ID if packet is
> intended for a MLO station and the station is not directly passed via
> pubsta function argument.
> 
> Add changes to pass the link ID information in Rx status.
> 
> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>

Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>

> ---
>  drivers/net/wireless/virtual/mac80211_hwsim.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/wireless/virtual/mac80211_hwsim.c b/drivers/net/wireless/virtual/mac80211_hwsim.c
> index b55fe320633c..783114ccb5b8 100644
> --- a/drivers/net/wireless/virtual/mac80211_hwsim.c
> +++ b/drivers/net/wireless/virtual/mac80211_hwsim.c
> @@ -1721,6 +1721,9 @@ static void mac80211_hwsim_rx(struct mac80211_hwsim_data *data,
>  				sp->active_links_rx &= ~BIT(link_id);
>  			else
>  				sp->active_links_rx |= BIT(link_id);
> +
> +			rx_status->link_valid = true;
> +			rx_status->link_id = link_id;
>  		}
>  		rcu_read_unlock();
>  	}
> 
> base-commit: e27b02e23a701e5761f1d6028643e1203a1c56de


      reply	other threads:[~2024-03-13 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 14:54 [PATCH] wifi: mac80211_hwsim: set link ID information during Rx Aditya Kumar Singh
2024-03-13 17:25 ` Jeff Johnson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a8cebda-c627-4876-b5e7-9edbad72ab1a@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_adisi@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).