From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6C4C4360C for ; Tue, 8 Oct 2019 20:16:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0E2121871 for ; Tue, 8 Oct 2019 20:16:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730819AbfJHUQl (ORCPT ); Tue, 8 Oct 2019 16:16:41 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:47940 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727570AbfJHUQl (ORCPT ); Tue, 8 Oct 2019 16:16:41 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.2) (envelope-from ) id 1iHvuR-00017J-Bf; Tue, 08 Oct 2019 22:16:39 +0200 Message-ID: <9c49ec27489333d7f27831de19e9d1c9cd65eeee.camel@sipsolutions.net> Subject: Re: [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature From: Johannes Berg To: Denis Kenzior , James Prestwood , linux-wireless@vger.kernel.org Date: Tue, 08 Oct 2019 22:16:38 +0200 In-Reply-To: <193168d4-6466-60a4-bc89-c4a44e84ac46@gmail.com> (sfid-20191008_205058_831848_E2C7643E) References: <20190913195908.7871-1-prestwoj@gmail.com> <20190913195908.7871-2-prestwoj@gmail.com> <90ae00044bc0834d87d3f9fb75ce63dce4cfadd5.camel@gmail.com> <0b57c1288016310050ccd6233dda886fc4a89b02.camel@gmail.com> <6fa34e4c-5c81-4875-da29-cada1a078e2c@gmail.com> <6530a6b06176790c5a6949d6ffccf37b506975bd.camel@sipsolutions.net> <864267ec-9158-940d-6e0e-db84a395888e@gmail.com> <1bb5450b-bc4e-8c83-f99e-fc7e739b08f0@gmail.com> <193168d4-6466-60a4-bc89-c4a44e84ac46@gmail.com> (sfid-20191008_205058_831848_E2C7643E) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2019-10-08 at 13:50 -0500, Denis Kenzior wrote: > Hi Johannes, > > > > But they shouldn't change due a mac address change? I wonder if we can > > > further relax the requirements to allow mac change if > > > NL80211_SCAN_FLAG_RANDOM_ADDR was used? > > > > No, at least with HW scan that would completely confuse the driver - > > since from the driver's POV we'd remove the interface it's currently > > managing the scan for. > > So help me understand this better. include/net/mac80211.h: int (*hw_scan)(struct ieee80211_hw *hw, struct ieee80211_vif *vif, struct ieee80211_scan_request *req); How is it difficult to understand that with an API like that, it might not be a good idea to remove the vif from the driver while it's scanning? > Just by virtue of copying the new > mac into sdata->vif.addr That's not what happens? johannes