From: Florian Fainelli <f.fainelli@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] cfg80211: select CRYPTO_SHA256 if needed
Date: Fri, 24 Nov 2017 13:17:14 -0800 [thread overview]
Message-ID: <9f8c14d6-d70d-693c-9ada-44d092f8d757@gmail.com> (raw)
In-Reply-To: <20171124083525.28735-1-johannes@sipsolutions.net>
On 11/24/2017 12:35 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> When regulatory database certificates are built-in, they're
> currently using the SHA256 digest algorithm, so add that to
> the build in that case.
>
> Also add a note that for custom certificates, one may need
> to add the right algorithms.
>
> Reported-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks for the quick fix!
> ---
> net/wireless/Kconfig | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> index da91bb547db3..1abcc4fc4df1 100644
> --- a/net/wireless/Kconfig
> +++ b/net/wireless/Kconfig
> @@ -20,6 +20,10 @@ config CFG80211
> tristate "cfg80211 - wireless configuration API"
> depends on RFKILL || !RFKILL
> select FW_LOADER
> + # may need to update this when certificates are changed and are
> + # using a different algorithm, though right now they shouldn't
> + # (this is here rather than below to allow it to be a module)
> + select CRYPTO_SHA256 if CFG80211_USE_KERNEL_REGDB_KEYS
> ---help---
> cfg80211 is the Linux wireless LAN (802.11) configuration API.
> Enable this if you have a wireless device.
> @@ -113,6 +117,9 @@ config CFG80211_EXTRA_REGDB_KEYDIR
> certificates like in the kernel sources (net/wireless/certs/)
> that shall be accepted for a signed regulatory database.
>
> + Note that you need to also select the correct CRYPTO_<hash> modules
> + for your certificates, and if cfg80211 is built-in they also must be.
> +
> config CFG80211_REG_CELLULAR_HINTS
> bool "cfg80211 regulatory support for cellular base station hints"
> depends on CFG80211_CERTIFICATION_ONUS
>
--
Florian
prev parent reply other threads:[~2017-11-24 21:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 8:35 [PATCH] cfg80211: select CRYPTO_SHA256 if needed Johannes Berg
2017-11-24 21:17 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f8c14d6-d70d-693c-9ada-44d092f8d757@gmail.com \
--to=f.fainelli@gmail.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).