Re: Current mainline brcmfmac reports error on supposedly supported ap6256 chip

[Piotr Oniszczuk <piotr.oniszczuk@gmail.com>]

Arend,

Neil Armstrong hinted me issue might be related to usage of memcpy() to/from an iomem mapping.
arm64 memcpy update (285133040e6c ("arm64: Import latest memcpy()/memmove() implementation")) triggers a memory abort when dram-access-quirk
is used on the G12A/G12B platforms.

I reverted https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/mmc/host/meson-gx-mmc.c?h=v5.13.4&id=103a5348c22c3fca8b96c735a9e353b8a0801842

and got nicely working wifi.

So it looks root cause is amlogic specific - not brcmfmac.

Sorry for false report and many many thx for Your head-up!
  
br

> Wiadomość napisana przez Arend van Spriel <arend.vanspriel@broadcom.com> w dniu 26.07.2021, o godz. 11:39:
> 
> On 7/26/2021 11:37 AM, Arend van Spriel wrote:
>> + linux-wireless, + Ondrej
>> Hoi Piotr,
>> Please reply to all. This might interest others with a similar device.
>> On 7/26/2021 11:31 AM, Piotr Oniszczuk wrote:
>>> Arend,
>>> 
>>> pls find dmesg with extra prints you proposed:
>>> 
>>> [  144.634234] brcmfmac: brcmfmac_module_init No platform data available.
>>> [  144.638974] brcmfmac: brcmf_sdio_probe Enter
>>> [  144.643057] brcmfmac: F1 signature read @0x18000000=0x15294345
>>> [  144.648718] brcmfmac: brcmf_chip_recognition found AXI chip: BCM4345/9
>>> [  144.656662] brcmfmac: brcmf_chip_cores_check  [1 ] core 0x800:51 base 0x18000000 wrap 0x18100000
>>> [  144.663690] brcmfmac: brcmf_chip_cores_check  [2 ] core 0x812:54 base 0x18001000 wrap 0x18101000
>>> [  144.672346] brcmfmac: brcmf_chip_cores_check  [3 ] core 0x83e:9  base 0x18002000 wrap 0x18102000
>>> [  144.681031] brcmfmac: brcmf_chip_cores_check  [4 ] core 0x83c:14 base 0x18003000 wrap 0x18103000
>>> [  144.689683] brcmfmac: brcmf_chip_cores_check  [5 ] core 0x829:21 base 0x18004000 wrap 0x18104000
>>> [  144.698365] brcmfmac: brcmf_chip_cores_check  [6 ] core 0x135:0  base 0x00000000 wrap 0x18107000
>>> [  144.707019] brcmfmac: brcmf_chip_cores_check  [7 ] core 0x240:0  base 0x00000000 wrap 0x00000000
>>> [  144.715678] brcmfmac: brcmf_chip_set_passive Enter
>>> [  144.722499] brcmfmac: brcmf_chip_tcm_ramsize: up 0 corecap 0 nab 0 nbb 0
>> I see. That helps. Let me come up with a patch for this.
>> [...]
>>> btw:
>>> to be sure about is my DT correct i done following tests:
>>> 1.boot my distro binary on other board with ap6256 (radxa-rockpi4b). works ok
>>> 2.selective disable wifi pwrseq and clock dt fragments. disabling stops chip detection so indirectly concluding my dt fragments seems to be ok
>> The fact that the wifi device is probed is enough proof. There may be some additional clocks needed, but for now it looks like SDIO bus is properly functioning to access the device.
> 
> ...but feel free to share the DT source so I can have a look.
> 
> Regards,
> Arend