archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <>
To: Felix Fietkau <>
	Jouni Malinen <>
Subject: Re: [PATCH 2/3] ath9k_hw: clean up per-channel calibration data
Date: Wed, 28 Jul 2010 13:52:27 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Jul 28, 2010 at 10:45 AM, Felix Fietkau <> wrote:
> The noise floor history buffer is currently not kept per channel, which
> can lead to problems when changing channels from a clean channel to a
> noisy one. Also when switching from HT20 to HT40, the noise floor
> history buffer is full of measurements, but none of them contain data
> for the extension channel, which it needs quite a bit of time to recover
> from.
> This patch puts all the per-channel calibration data into a single data
> structure, and gives the the driver control over whether that is used
> per-channel or even not used for some channels.
> For ath9k_htc, I decided to keep this per-channel in order to avoid
> creating regressions.
> For ath9k, the data is kept only for the operating channel, which saves
> some space. ath9k_hw takes care of wiping old data when the operating
> channel or its channel flags change.
> Signed-off-by: Felix Fietkau <>

But this also means every time we want to get operational on a channel
we have to learn the current noise all over again. This means for WiFi
Direct every channel swap we'd have to learn to walk, which happens
quite often. What do you think? Sorry, I know we discussed this
approach and I seemed fine but this just occurred to me now, and will
become really important later when we support WiFi Direct.


  parent reply	other threads:[~2010-07-28 20:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 17:45 [PATCH 1/3] ath9k: prevent calibration during off-channel activity Felix Fietkau
2010-07-28 17:45 ` [PATCH 2/3] ath9k_hw: clean up per-channel calibration data Felix Fietkau
2010-07-28 17:45   ` [PATCH 3/3] ath9k_hw: fix a noise floor calibration related race condition Felix Fietkau
2010-07-28 20:52   ` Luis R. Rodriguez [this message]
2010-07-28 21:10     ` [PATCH 2/3] ath9k_hw: clean up per-channel calibration data Felix Fietkau
2010-07-28 21:21       ` Luis R. Rodriguez
2010-07-28 21:30         ` Felix Fietkau
2010-07-28 21:40           ` Luis R. Rodriguez
2010-07-28 22:03             ` Felix Fietkau
2010-07-28 20:43 ` [PATCH 1/3] ath9k: prevent calibration during off-channel activity Luis R. Rodriguez
2010-07-28 21:08   ` Felix Fietkau
2010-07-28 22:12     ` Luis R. Rodriguez
2010-07-28 22:28       ` Felix Fietkau
2010-07-28 22:47         ` Luis R. Rodriguez
2010-07-28 22:48           ` Luis R. Rodriguez
2010-07-29 16:58             ` wireless-next-2.6 rebase -- " John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).