From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Wojciech Dubowik <dubowoj@neratec.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/9] ath5k: AHB port. Use ath_bus_opts structure.
Date: Thu, 11 Nov 2010 10:31:49 -0800 [thread overview]
Message-ID: <AANLkTi=pPi02QskWK3zMzuMBpzOhpD5sJGYTNn8hmRbK@mail.gmail.com> (raw)
In-Reply-To: <11581781.1031289487462262.JavaMail.wlan@CHBU500181>
On Thu, Nov 11, 2010 at 6:57 AM, Wojciech Dubowik <dubowoj@neratec.com> wrote:
> In main ath folder ath_bus_opts is used to specify AHB/PCI/USB specific functions. Use it for ath5k since it's needed for AHB support.
> PCI initialization has been split to bus specific and common which have been moved to ath5k_attach.
>
> Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
Your patch commit log entry is way too long. Please trim it to around
76 characters per line or less. Also I'd prefer to help the reader of
the code and make it clear that the work you do in ath5k_attach() is
just to initialize the softc struct so please instead rename the
routine to ath5k_init_softc() just as we do that in ath9k while you're
at it. Later on (on a separate patch or series) you can also then
rename ath5k_hw_attach() to ath5k_hw_init() as we did so on ath9k.
Luis
prev parent reply other threads:[~2010-11-11 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7180198.951289487321198.JavaMail.wlan@CHBU500181>
2010-11-11 14:57 ` [PATCH 2/9] ath5k: AHB port. Use ath_bus_opts structure Wojciech Dubowik
2010-11-11 18:31 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=pPi02QskWK3zMzuMBpzOhpD5sJGYTNn8hmRbK@mail.gmail.com' \
--to=mcgrof@gmail.com \
--cc=dubowoj@neratec.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).