From: Bob Copeland <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [ath5k-devel] [PATCH] ath5k: add led_disable module option
Date: Wed, 28 Jul 2010 17:14:03 -0400 [thread overview]
Message-ID: <AANLkTik-0nOnKxnUOr1DFA_1WbTDNoOQYP3qn_vMesCF@mail.gmail.com> (raw)
In-Reply-To: <1280351044.3732.0.camel@jlt3.sipsolutions.net>
On Wed, Jul 28, 2010 at 5:04 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Wed, 2010-07-28 at 14:01 -0700, Luis R. Rodriguez wrote:
>> On Wed, Jul 28, 2010 at 9:31 AM, John W. Linville
>> <linville@tuxdriver.com> wrote:
>> > Not everyone agrees about LED behaviour...give them an escape hatch that
>> > will at least stop the lights from annoying them.
>> >
>> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
>>
>> I wonder if we can just do this on cfg80211 through a debugfs knob,
>> which would take care of all device drivers?
>
> We have proper API for this in sysfs if anybody bothered to hook this up
> through the LED class/trigger system
Yes, they are hooked up through the triggers, so you can disable
them via sysfs (which I have told several people, but complaints still
roll in...)
I don't have any devices with LEDs so either way I don't care too much.
--
Bob Copeland %% www.bobcopeland.com
prev parent reply other threads:[~2010-07-28 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 16:31 [PATCH] ath5k: add led_disable module option John W. Linville
2010-07-28 17:10 ` Bob Copeland
2010-07-28 21:01 ` [ath5k-devel] " Luis R. Rodriguez
2010-07-28 21:04 ` Johannes Berg
2010-07-28 21:14 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik-0nOnKxnUOr1DFA_1WbTDNoOQYP3qn_vMesCF@mail.gmail.com \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).