From: Ohad Ben-Cohen <ohad@wizery.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Roger Quadros <roger.quadros@nokia.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
Chikkature Rajashekar Madhusudhan <madhu.cr@ti.com>,
"Coelho Luciano (Nokia-MS/Helsinki)" <Luciano.Coelho@nokia.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
San Mehat <san@google.com>, Tony Lindgren <tony@atomide.com>,
Pandita Vikram <vikram.pandita@ti.com>,
Kalle Valo <kalle.valo@iki.fi>
Subject: Re: [PATCH v2 18/20] mmc: sdio: enable a default power off mode of the card
Date: Sun, 25 Jul 2010 17:05:39 +0300 [thread overview]
Message-ID: <AANLkTimjoMFwc=Bu=vfoODW2XiiuRN9iPcAAOwU6Sfpz@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1007250953400.25246@xanadu.home>
On Sun, Jul 25, 2010 at 4:56 PM, Nicolas Pitre <nico@fluxnic.net> wrote:
> On Sun, 25 Jul 2010, Ohad Ben-Cohen wrote:
>
>> On Thu, Jul 22, 2010 at 2:35 PM, Roger Quadros <roger.quadros@nokia.com> wrote:
>> > On 07/21/2010 08:33 PM, ext Ohad Ben-Cohen wrote:
>> >>
>> >> Add support for an SDIO device to stay powered off even without
>> >> the presence of an SDIO function driver. A host should explicitly
>> >> ask for it by means of MMC_CAP_DONT_POWER_CARD, and the SDIO
>> >> function driver should know it needs to call sdio_claim_power
>> >> before accessing the device.
>> >>
>> >> Signed-off-by: Ohad Ben-Cohen<ohad@wizery.com>
>> >
>> > Shouldn't this be the default behaviour? If there is no function driver for
>> > any of the functions of the card, then sdio core shold power off the card.
>> >
>> > I don't see a need for a special capability flag for this.
>> >
>> > in fact MMC_CAP_DONT_POWER_CARD does not seem like an mmc host's capability
>>
>> Totally agree.
>>
>> I didn't want to change the current behavior of the cards/funcs so I
>> looked for a way to explicitly power down only specific cards.
>>
>> Alternatively we could power down all cards at the end
>> mmc_attach_sdio, and then power them up selectively in sdio_bus_probe,
>> just before calling probe. If the probe succeeds, the function driver
>> takes over. If the probe fails, we can power them down again.
>
> Exactly!
Ok, v3 is on the way :)
(featuring no special host CAP, fix locking issues, and power down
unclaimed cards also on resume)
next prev parent reply other threads:[~2010-07-25 14:06 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 17:33 [PATCH v2 00/20] native support for wl1271 on ZOOM Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 01/20] sdio: add TI + wl1271 ids Ohad Ben-Cohen
2010-07-21 17:58 ` Marcel Holtmann
2010-07-22 23:38 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 02/20] wireless: wl1271: remove SDIO IDs from driver Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 03/20] mmc: support embedded data field in mmc_host Ohad Ben-Cohen
2010-07-28 19:47 ` Vitaly Wool
2010-07-29 6:00 ` Ohad Ben-Cohen
2010-07-29 16:16 ` Vitaly Wool
2010-08-02 15:54 ` Ohad Ben-Cohen
2010-08-02 16:25 ` Vitaly Wool
2010-08-02 21:35 ` Ohad Ben-Cohen
2010-08-03 14:17 ` Vitaly Wool
2010-08-04 11:24 ` Ohad Ben-Cohen
2010-08-04 11:41 ` Russell King - ARM Linux
2010-08-04 12:42 ` Ohad Ben-Cohen
2010-08-04 14:01 ` Vitaly Wool
2010-08-06 7:07 ` Linus Walleij
2010-08-06 10:02 ` Ohad Ben-Cohen
2010-08-06 14:46 ` Russell King - ARM Linux
2010-08-06 16:53 ` Nicolas Pitre
2010-07-21 17:33 ` [PATCH v2 04/20] omap zoom2: wlan board muxing Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 05/20] omap zoom3: " Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 06/20] wireless: wl1271: make wl12xx.h common to both spi and sdio Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 07/20] wireless: wl1271: support return value for the set power func Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 08/20] wireless: wl1271: take irq info from private board data Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 09/20] wireless: wl1271: make ref_clock configurable by board Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan Ohad Ben-Cohen
2010-07-21 17:59 ` Mark Brown
2010-07-22 11:16 ` Roger Quadros
2010-07-22 23:13 ` Ohad Ben-Cohen
2010-07-23 9:15 ` Mark Brown
2010-07-25 10:40 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 11/20] omap: hsmmc: support mmc3 regulator power control Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 12/20] omap: hsmmc: allow board-specific settings of private mmc data Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 13/20] omap: zoom: add mmc3/wl1271 device support Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 14/20] mmc: sdio: fully reconfigure oldcard on resume Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 15/20] mmc: sdio: verify existence of resume handler Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 16/20] mmc: introduce API to control the card's power Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 17/20] mmc: sdio: relocate sdio_set_block_size call Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 18/20] mmc: sdio: enable a default power off mode of the card Ohad Ben-Cohen
2010-07-22 11:35 ` Roger Quadros
2010-07-25 12:40 ` Ohad Ben-Cohen
2010-07-25 13:56 ` Nicolas Pitre
2010-07-25 14:05 ` Ohad Ben-Cohen [this message]
2010-07-21 17:33 ` [PATCH v2 19/20] omap: zoom: keep the MMC3 wl1271 device powered off Ohad Ben-Cohen
2010-07-21 18:55 ` Gabay, Benzy
2010-07-22 23:18 ` Ohad Ben-Cohen
2010-07-26 18:33 ` Gabay, Benzy
2010-07-21 17:33 ` [PATCH v2 20/20] wireless: wl1271: call SDIO claim/release power API Ohad Ben-Cohen
2010-07-22 22:56 ` [PATCH v2 00/20] native support for wl1271 on ZOOM Nicolas Pitre
2010-07-22 23:56 ` Ohad Ben-Cohen
2010-07-26 19:30 ` John W. Linville
2010-07-27 9:32 ` Ohad Ben-Cohen
2010-08-02 8:16 ` Luciano Coelho
2010-08-02 11:42 ` Tony Lindgren
2010-08-02 12:08 ` Ohad Ben-Cohen
2010-08-02 15:12 ` Vitaly Wool
2010-08-02 15:59 ` Ohad Ben-Cohen
2010-08-02 16:19 ` Vitaly Wool
2010-08-02 16:40 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimjoMFwc=Bu=vfoODW2XiiuRN9iPcAAOwU6Sfpz@mail.gmail.com' \
--to=ohad@wizery.com \
--cc=Luciano.Coelho@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=kalle.valo@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=madhu.cr@ti.com \
--cc=nico@fluxnic.net \
--cc=roger.quadros@nokia.com \
--cc=san@google.com \
--cc=tony@atomide.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).