From: Sedat Dilek <sedat.dilek@googlemail.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] iwl3945: remove unused len_org variable
Date: Fri, 12 Nov 2010 09:19:42 +0100 [thread overview]
Message-ID: <AANLkTimuS1_2=ZBX0BXP_EeOq92iR9to0bFtxgi9HpZ1@mail.gmail.com> (raw)
In-Reply-To: <1289548027-3383-1-git-send-email-sgruszka@redhat.com>
Against which GIT tree has your patchset to be applied?
- Sedat -
On Fri, Nov 12, 2010 at 8:47 AM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
> drivers/net/wireless/iwlwifi/iwl3945-base.c | 9 +--------
> 1 files changed, 1 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> index 931c546..f2ce7dd 100644
> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> @@ -475,7 +475,7 @@ static int iwl3945_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
> dma_addr_t phys_addr;
> dma_addr_t txcmd_phys;
> int txq_id = skb_get_queue_mapping(skb);
> - u16 len, idx, len_org, hdr_len; /* TODO: len_org is not used */
> + u16 len, idx, hdr_len;
> u8 id;
> u8 unicast;
> u8 sta_id;
> @@ -612,15 +612,8 @@ static int iwl3945_tx_skb(struct iwl_priv *priv, struct sk_buff *skb)
> */
> len = sizeof(struct iwl3945_tx_cmd) +
> sizeof(struct iwl_cmd_header) + hdr_len;
> -
> - len_org = len;
> len = (len + 3) & ~3;
>
> - if (len_org != len)
> - len_org = 1;
> - else
> - len_org = 0;
> -
> /* Physical address of this Tx command's header (not MAC header!),
> * within command buffer array. */
> txcmd_phys = pci_map_single(priv->pci_dev, &out_cmd->hdr,
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-11-12 8:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 7:47 [PATCH 1/3] iwl3945: remove unused len_org variable Stanislaw Gruszka
2010-11-12 7:47 ` [PATCH 2/3] iwlagn: simplify iwlagn_tx_skb Stanislaw Gruszka
2010-11-12 15:52 ` Guy, Wey-Yi
2010-11-12 16:46 ` Stanislaw Gruszka
2010-11-12 17:51 ` Guy, Wey-Yi
2010-11-12 7:47 ` [PATCH 3/3] iwlwifi: kill elapsed_jiffies Stanislaw Gruszka
2010-11-12 15:53 ` Guy, Wey-Yi
2010-11-12 8:19 ` Sedat Dilek [this message]
2010-11-12 8:56 ` [PATCH 1/3] iwl3945: remove unused len_org variable Stanislaw Gruszka
2010-11-12 15:32 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimuS1_2=ZBX0BXP_EeOq92iR9to0bFtxgi9HpZ1@mail.gmail.com' \
--to=sedat.dilek@googlemail.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=sgruszka@redhat.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).