From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:47862 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753125Ab0HKVkN (ORCPT ); Wed, 11 Aug 2010 17:40:13 -0400 MIME-Version: 1.0 In-Reply-To: References: <1281550913-17633-1-git-send-email-ohad@wizery.com> <1281550913-17633-4-git-send-email-ohad@wizery.com> <5A47E75E594F054BAF48C5E4FC4B92AB0324110ABD@dbde02.ent.ti.com> <20100811184742.GA21778@nokia.com> Date: Wed, 11 Aug 2010 23:34:49 +0200 Message-ID: Subject: Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data From: Vitaly Wool To: Ohad Ben-Cohen Cc: felipe.balbi@nokia.com, Kalle Valo , "Pandita, Vikram" , "akpm@linux-foundation.org" , "Quadros Roger (Nokia-MS/Helsinki)" , Tony Lindgren , "linux-wireless@vger.kernel.org" , Nicolas Pitre , Mark Brown , "linux-mmc@vger.kernel.org" , Ido Yariv , San Mehat , "Chikkature Rajashekar, Madhusudhan" , "Coelho Luciano (Nokia-MS/Helsinki)" , "linux-omap@vger.kernel.org" , "ext DebBarma, Tarun Kanti" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Ohad, On Wed, Aug 11, 2010 at 10:10 PM, Ohad Ben-Cohen wrote: > Think of several wl1271 devices, each of which is represented by two > devices; an SDIO function, and a platform device. The SDIO function > stands for a specific MMC controller the device is hardwired to, and > the platform device stands for the external irq line that the device > is hardwired to. my view on this is that you're hunting the false problem here. I wonder how likely it is that two hardwired WL12xx chips are there on the same board. It's theoretically possible that there's one hardwired device and one hot-pluggable one but the latter one can't have platform_data anyway. So in my opinion, we either should keep things simple and consider 2 hardwired WL12XX's to be a very very unlikely case, or we'll end up discussing board_info once again. Thanks, Vitaly