From: "Otcheretianski, Andrei" <andrei.otcheretianski@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Srinivas Dasari <dasaris@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] cfg80211: Authentication offload to user space in AP mode
Date: Tue, 18 Dec 2018 13:40:21 +0000 [thread overview]
Message-ID: <B2CD83211F5FDD478D7EFFF030D107EDCD031EAB@HASMSX111.ger.corp.intel.com> (raw)
In-Reply-To: <dd3263b2b3f0850a26b316f9e8cb0cba81dc97c7.camel@sipsolutions.net>
> So, interesting - Andrei also added the PMKID but also the PMK here, in a
> separate patch:
> https://patchwork.kernel.org/patch/10732093/
Yeah, PMK is needed for the devices that offload 4way handshake.
>>[...]
> > - if (!info->attrs[NL80211_ATTR_SSID])
> > + if (!info->attrs[NL80211_ATTR_SSID] &&
> > + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
> > + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN &&
> > + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_P2P_GO)
> > return -EINVAL;
>
> Hm. do we really expect this on AP_VLAN?
Actually I'm not sure about GO neither. P2P doesn't use SAE etc..
Andrei
>
> johannes
next prev parent reply other threads:[~2018-12-18 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 9:31 [PATCH] cfg80211: Authentication offload to user space in AP mode Srinivas Dasari
2018-12-18 13:28 ` Johannes Berg
2018-12-18 13:40 ` Otcheretianski, Andrei [this message]
2018-12-20 11:07 ` dasaris
2019-01-15 13:26 ` Johannes Berg
2019-01-23 12:28 ` dasaris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B2CD83211F5FDD478D7EFFF030D107EDCD031EAB@HASMSX111.ger.corp.intel.com \
--to=andrei.otcheretianski@intel.com \
--cc=dasaris@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).