From: Russell Joyce <russell.joyce@york.ac.uk>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Alan Millard" <alan.millard@york.ac.uk>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
"Wright Feng" <wright.feng@cypress.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"James Hughes" <james.hughes@raspberrypi.org>,
"Tobias Klauser" <tklauser@distanz.ch>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<brcm80211-dev-list.pdl@broadcom.com>,
brcm80211-dev-list@cypress.com,
"Network Development" <netdev@vger.kernel.org>
Subject: Re: [PATCH] brcmfmac: added LED triggers for transmit/receive
Date: Tue, 11 Jul 2017 16:01:16 +0100 [thread overview]
Message-ID: <C53F8AC9-8F95-4191-A1E4-177AA1D0DA20@york.ac.uk> (raw)
In-Reply-To: <60de1301-b4a3-95a7-117f-a953576655d9@broadcom.com>
Thanks for your comments.
> What I think Rafa=C5=82 is saying is that it would be better to have =
this
> code in cfg80211 so other drivers including mac80211 could use it.
While I agree that moving all wireless LED triggers to cfg80211 would be =
an
ideal situation, it seems a bit out of scope for what I was trying to =
achieve.
This would probably also require removing the mac80211 LED triggers (and =
any
other similar triggers that might be created by specific wireless =
drivers not
using mac80211), in order to consolidate them in one place.
Besides this, I'm not sure where exactly in cfg80211 this functionality =
would
go (I assume it was originally put in mac80211 instead for a reason?),
although I'm certainly no expert in this area of the kernel.
> Indeed. However, the LED subsystem could/should(?) take care of =
mapping
> "rx" and "tx" triggers to the same LED.
In terms of the LED triggers, the only alternative I can see is to =
create a
single complex trigger that exposes "rx" and "tx" parameters that can be
individually enabled or disabled. This would reduce the number of =
triggers from
three to one, but also makes things slightly more awkward for the user, =
and
deviates from the convention set by mac80211.
next prev parent reply other threads:[~2017-07-11 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 14:09 [PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce
2017-07-10 9:48 ` Rafał Miłecki
2017-07-10 17:02 ` Russell Joyce
2017-07-11 8:58 ` Arend van Spriel
2017-07-11 15:01 ` Russell Joyce [this message]
2017-07-17 4:59 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C53F8AC9-8F95-4191-A1E4-177AA1D0DA20@york.ac.uk \
--to=russell.joyce@york.ac.uk \
--cc=alan.millard@york.ac.uk \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=james.hughes@raspberrypi.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mhiramat@kernel.org \
--cc=mkl@pengutronix.de \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=rafal@milecki.pl \
--cc=tklauser@distanz.ch \
--cc=wright.feng@cypress.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).