archive mirror
 help / color / mirror / Atom feed
From: Russell Joyce <>
To: Arend van Spriel <>
Cc: "Rafał Miłecki" <>,
	"Alan Millard" <>,
	"Franky Lin" <>,
	"Hante Meuleman" <>,
	"Chi-Hsien Lin" <>,
	"Wright Feng" <>,
	"Kalle Valo" <>,
	"Marc Kleine-Budde" <>,
	"Marcel Holtmann" <>,
	"Michael S. Tsirkin" <>,
	"Pieter-Paul Giesberts" <>,
	"Rafał Miłecki" <>,
	"" <>,
	"James Hughes" <>,
	"Tobias Klauser" <>,
	"Linux Kernel Mailing List" <>,
	"" <>,
	"Network Development" <>
Subject: Re: [PATCH] brcmfmac: added LED triggers for transmit/receive
Date: Tue, 11 Jul 2017 16:01:16 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Thanks for your comments.

> What I think Rafa=C5=82 is saying is that it would be better to have =
> code in cfg80211 so other drivers including mac80211 could use it.

While I agree that moving all wireless LED triggers to cfg80211 would be =
ideal situation, it seems a bit out of scope for what I was trying to =
This would probably also require removing the mac80211 LED triggers (and =
other similar triggers that might be created by specific wireless =
drivers not
using mac80211), in order to consolidate them in one place.

Besides this, I'm not sure where exactly in cfg80211 this functionality =
go (I assume it was originally put in mac80211 instead for a reason?),
although I'm certainly no expert in this area of the kernel.

> Indeed. However, the LED subsystem could/should(?) take care of =
> "rx" and "tx" triggers to the same LED.

In terms of the LED triggers, the only alternative I can see is to =
create a
single complex trigger that exposes "rx" and "tx" parameters that can be
individually enabled or disabled. This would reduce the number of =
triggers from
three to one, but also makes things slightly more awkward for the user, =
deviates from the convention set by mac80211.

  reply	other threads:[~2017-07-11 15:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 14:09 [PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce
2017-07-10  9:48 ` Rafał Miłecki
2017-07-10 17:02   ` Russell Joyce
2017-07-11  8:58     ` Arend van Spriel
2017-07-11 15:01       ` Russell Joyce [this message]
2017-07-17  4:59         ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).