linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Boyer <jwboyer@kernel.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Tony Chuang <yhchuang@realtek.com>,
	"linux-firmware@kernel.org" <linux-firmware@kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
	"briannorris@chromium.org" <briannorris@chromium.org>
Subject: Re: [PATCH v2 2/2] rtw88: RTL8822C: add WoW firmware v7.3
Date: Wed, 7 Aug 2019 12:20:44 -0400	[thread overview]
Message-ID: <CA+5PVA4LDjCtPW8HAve79inmihT_6BDp899HGx_7P-4U3H7NaA@mail.gmail.com> (raw)
In-Reply-To: <7bbbe3be-1f6f-8f38-45f3-54f25a5b2f38@broadcom.com>

On Wed, Aug 7, 2019 at 6:15 AM Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
>
>
> On 8/7/2019 11:53 AM, Tony Chuang wrote:
> >> From: Arend Van Spriel [mailto:arend.vanspriel@broadcom.com]
> >>
> >> On 8/7/2019 10:48 AM, yhchuang@realtek.com wrote:
> >>> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >>>
> >>> Add WoW firmware to support entering Wake on WirelessLAN mode
> >>>
> >>> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >>> ---
> >>>
> >>> v1 -> v2
> >>>      * update WHENCE file for new added firmware
> >>>
> >>>    WHENCE                    |   1 +
> >>>    rtw88/rtw8822c_wow_fw.bin | Bin 0 -> 138720 bytes
> >>>    2 files changed, 1 insertion(+)
> >>>    create mode 100755 rtw88/rtw8822c_wow_fw.bin
> >>
> >> Just wondering: Is this a good approach? What firmware should distros
> >> pick? Is there a trade-off affecting other wifi functionality when using
> >> WoW firmware?
> >>
> >
> > If distros want to use WOW, they should pick both.
> >
> > For Realtek devices such as RTL8822CE, it needs to "change/re-download"
> > the wow firmware to suspend with WOW functionalities. When resume,
> > switch back to normal firmware to run "normally".
> >
> > I think the reason is the firmware size restriction. For newer devices,
> > maybe there is a larger space for firmware, and we don't need to swap
> > the FW like this :)
>
> Interesting approach and I would mention this in the commit message or
> add a README in rtw88 folder explaining it. Not sure whether distros
> look at commit messages.

A README would indeed be nice.  Can you do a v3 with that included?

josh

      reply	other threads:[~2019-08-07 16:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07  8:48 [PATCH v2 1/2] rtw88: RTL8822C: update rtw8822c_fw.bin to v7.3 yhchuang
2019-08-07  8:48 ` [PATCH v2 2/2] rtw88: RTL8822C: add WoW firmware v7.3 yhchuang
2019-08-07  9:33   ` Arend Van Spriel
2019-08-07  9:53     ` Tony Chuang
2019-08-07 10:15       ` Arend Van Spriel
2019-08-07 16:20         ` Josh Boyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+5PVA4LDjCtPW8HAve79inmihT_6BDp899HGx_7P-4U3H7NaA@mail.gmail.com \
    --to=jwboyer@kernel.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=briannorris@chromium.org \
    --cc=linux-firmware@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).