From: Franky Lin <franky.lin@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Franky Lin" <frankyl@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
"Wright Feng" <wright.feng@cypress.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Douglas Anderson" <dianders@chromium.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Naveen Gupta" <naveen.gupta@cypress.com>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<linux-wireless@vger.kernel.org>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<brcm80211-dev-list.pdl@broadcom.com>,
brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: Fix use after free in brcmf_sdio_readframes()
Date: Tue, 3 Dec 2019 10:42:20 -0800 [thread overview]
Message-ID: <CA+8PC_ehSW=-eVC0qAbh-m+8WHwKrmbYWrhmX8w4ovGS8TVE0w@mail.gmail.com> (raw)
In-Reply-To: <20191203095855.c4fradmsixgbq7mc@kili.mountain>
On Tue, Dec 3, 2019 at 1:59 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The brcmu_pkt_buf_free_skb() function frees "pkt" so it leads to a
> static checker warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1974 brcmf_sdio_readframes()
> error: dereferencing freed memory 'pkt'
>
> It looks like there was supposed to be a continue after we free "pkt".
Good catch!
Acked-by: Franky Lin <franky.lin@broadcom.com>
>
> Fixes: 4754fceeb9a6 ("brcmfmac: streamline SDIO read frame routine")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static analysis. Not tested.
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> index 264ad63232f8..1dea0178832e 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> @@ -1935,6 +1935,7 @@ static uint brcmf_sdio_readframes(struct brcmf_sdio *bus, uint maxframes)
> BRCMF_SDIO_FT_NORMAL)) {
> rd->len = 0;
> brcmu_pkt_buf_free_skb(pkt);
> + continue;
> }
> bus->sdcnt.rx_readahead_cnt++;
> if (rd->len != roundup(rd_new.len, 16)) {
> --
> 2.11.0
>
next prev parent reply other threads:[~2019-12-03 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 9:58 [PATCH] brcmfmac: Fix use after free in brcmf_sdio_readframes() Dan Carpenter
2019-12-03 18:42 ` Franky Lin [this message]
2019-12-18 18:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+8PC_ehSW=-eVC0qAbh-m+8WHwKrmbYWrhmX8w4ovGS8TVE0w@mail.gmail.com' \
--to=franky.lin@broadcom.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=dan.carpenter@oracle.com \
--cc=dianders@chromium.org \
--cc=frankyl@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=naveen.gupta@cypress.com \
--cc=rafal@milecki.pl \
--cc=ulf.hansson@linaro.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).