From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB865FA372A for ; Wed, 16 Oct 2019 16:53:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D31B21835 for ; Wed, 16 Oct 2019 16:53:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SgnYlzte" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406511AbfJPQxY (ORCPT ); Wed, 16 Oct 2019 12:53:24 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:43449 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406479AbfJPQxX (ORCPT ); Wed, 16 Oct 2019 12:53:23 -0400 Received: by mail-qk1-f196.google.com with SMTP id h126so23399730qke.10 for ; Wed, 16 Oct 2019 09:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vbf2jr/JDDqbj9QeMSOR2Sm/HO2E7m/FtsJ62e/Cquk=; b=SgnYlzteSEDL6KMKkljl8h2XrjlmA4dX3teKW005qDYWPeYwV12TOB+l+gkOFX+uJx AN46B1If921/dmZVDZp448B3guKbuIMLQKDls58FJD43TmJfZNljIoAdb0IrGK0NUyM6 /Thk555CGjZDy6LJjyS17bCw+Z67gU37bSZnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vbf2jr/JDDqbj9QeMSOR2Sm/HO2E7m/FtsJ62e/Cquk=; b=sYQ7X5Zwvu8IXuzBKbIDoKS/OHGoS2Dh4QvvKxI41amjMeLWkDi3Q3NWD7lLhpZZI6 OgZL/bTumDvRjc5I/pyzegdGMGFLREqjEyLdaP/vi4bLaTFVi+o+EYKfh/n7S9F6V/ss Rwvklk5kgJukHdlOK/pc4MLLObz1YEkgmLBIuul2kGZwZ6xosa/DeAYPkw3POvPsCjHp T7r/2LAHtNKzKGGTwVKyYfyOfgx1os5dwTuht2JjukI+fq1eL6Bpq5I/2kBx5+UpMOdL mxUe+2wtymcgkmZl3QwOkScBysCnrtQOVq6cvpdd92ZVcSL8HJnyUyVYTNx3LkEb1yVm h+Ug== X-Gm-Message-State: APjAAAX21s8d1rl8Q1Tg7bO6yisho6bURcTFT219qgp3bs7aMsbT2HtX A8wgXQIJtntZGL5/zsfXJItYUlYmpdc= X-Google-Smtp-Source: APXvYqwq2CEwtVe/husfcFprKypNXZzEAttUSYnnz6vorkqv0seQ2AEV0D4xD5rJQSRA4OKkPpdpzw== X-Received: by 2002:a37:4a87:: with SMTP id x129mr41127627qka.43.1571244801347; Wed, 16 Oct 2019 09:53:21 -0700 (PDT) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com. [209.85.160.179]) by smtp.gmail.com with ESMTPSA id l189sm11516935qke.69.2019.10.16.09.53.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 09:53:20 -0700 (PDT) Received: by mail-qt1-f179.google.com with SMTP id r5so37165033qtd.0 for ; Wed, 16 Oct 2019 09:53:19 -0700 (PDT) X-Received: by 2002:aed:3847:: with SMTP id j65mr46621346qte.124.1571244799397; Wed, 16 Oct 2019 09:53:19 -0700 (PDT) MIME-Version: 1.0 References: <20191016123301.2649-1-yhchuang@realtek.com> <20191016123301.2649-5-yhchuang@realtek.com> In-Reply-To: <20191016123301.2649-5-yhchuang@realtek.com> From: Brian Norris Date: Wed, 16 Oct 2019 09:53:08 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/6] rtw88: update regulatory settings implementaion To: Tony Chuang Cc: Kalle Valo , linux-wireless Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Oct 16, 2019 at 5:33 AM wrote: > This also supports user regulatory hints, and it should only be > enabled for specific distributions that need this to correct > the cards reglutory. s/cards/card's/ s/reglutory/regulatory/ There should be a pretty high bar for introducing either new CONFIG_* options or module parameters, in my opinion, and I'm not sure you really satisfied it. Why "should only be enabled" by certain distributions? Your opinion? If it's the technical limitation you refer to ("efuse settings"), then just detect the efuse and prevent user hints only on those modules. Brian