From: Brian Norris <briannorris@chromium.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH v3 2/3] rtw88: enclose c2h cmd handle with mutex
Date: Fri, 16 Aug 2019 18:29:43 -0700 [thread overview]
Message-ID: <CA+ASDXO2eoHW62Nmw1XNK_HAMgD=8AVNpAtsEod2RZibWZEy9g@mail.gmail.com> (raw)
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D18914D3@RTITMBSVM04.realtek.com.tw>
On Thu, Aug 15, 2019 at 7:45 PM Tony Chuang <yhchuang@realtek.com> wrote:
> I think the problem here is I should give a better comment to better
> describe the usage of the mutex. And I also want to keep it short.
I don't think we have limits on comments in source code -- better to
document too much than not enough.
Brian
next prev parent reply other threads:[~2019-08-17 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 12:22 [PATCH v3 0/3] rtw88: add support for BT co-existence mechanism yhchuang
2019-07-31 12:22 ` [PATCH v3 1/3] rtw88: allow c2h operation in irq context yhchuang
2019-08-06 12:42 ` Kalle Valo
2019-07-31 12:22 ` [PATCH v3 2/3] rtw88: enclose c2h cmd handle with mutex yhchuang
2019-08-15 21:11 ` Brian Norris
2019-08-16 2:45 ` Tony Chuang
2019-08-17 1:29 ` Brian Norris [this message]
2019-07-31 12:22 ` [PATCH v3 3/3] rtw88: add BT co-existence support yhchuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+ASDXO2eoHW62Nmw1XNK_HAMgD=8AVNpAtsEod2RZibWZEy9g@mail.gmail.com' \
--to=briannorris@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).