From: Brian Norris <briannorris@chromium.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Amitkumar Karwar <amitkarwar@gmail.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
Xinming Hu <huxinming820@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
huangwen@venustech.com.cn, Solar Designer <solar@openwall.com>,
Marcus Meissner <meissner@suse.de>
Subject: Re: [PATCH 2/2] mwifiex: Abort at too short BSS descriptor element
Date: Thu, 13 Jun 2019 13:26:27 -0700 [thread overview]
Message-ID: <CA+ASDXOCHsqmiEEDso2SzaiqkmrftdDvCm=auV-ucymWSXOPaA@mail.gmail.com> (raw)
In-Reply-To: <20190613183835.GA16432@google.com>
On Thu, Jun 13, 2019 at 11:38 AM Brian Norris <briannorris@chromium.org> wrote:
> So, I might say:
>
> /* Vendor IEs must at least contain the OUI. */
> if (total_ie_len < offsetof(struct ieee80211_vendor_ie, oui_type))
> return -EINVAL;
>
> /* If the IE still isn't long enough, it's not a match. */
> if (element_len < sizeof(wpa_oui))
> continue;
That would of course need to be break, not continue, to properly skip
to the next IE.
Brian
next prev parent reply other threads:[~2019-06-13 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 12:52 [PATCH 0/2] Buffer overflow / read checks in mwifiex Takashi Iwai
2019-05-29 12:52 ` [PATCH 1/2] mwifiex: Fix possible buffer overflows at parsing bss descriptor Takashi Iwai
2019-05-30 11:22 ` Kalle Valo
2019-05-29 12:52 ` [PATCH 2/2] mwifiex: Abort at too short BSS descriptor element Takashi Iwai
2019-06-13 17:49 ` Brian Norris
2019-06-13 18:12 ` Takashi Iwai
2019-06-13 18:38 ` Brian Norris
2019-06-13 20:26 ` Brian Norris [this message]
2019-06-15 0:19 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+ASDXOCHsqmiEEDso2SzaiqkmrftdDvCm=auV-ucymWSXOPaA@mail.gmail.com' \
--to=briannorris@chromium.org \
--cc=amitkarwar@gmail.com \
--cc=gbhat@marvell.com \
--cc=huangwen@venustech.com.cn \
--cc=huxinming820@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meissner@suse.de \
--cc=nishants@marvell.com \
--cc=solar@openwall.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).