From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87084C31E45 for ; Thu, 13 Jun 2019 20:26:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 560042054F for ; Thu, 13 Jun 2019 20:26:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gFwRaPbC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729016AbfFMU0n (ORCPT ); Thu, 13 Jun 2019 16:26:43 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:43683 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbfFMU0n (ORCPT ); Thu, 13 Jun 2019 16:26:43 -0400 Received: by mail-lf1-f68.google.com with SMTP id j29so93721lfk.10 for ; Thu, 13 Jun 2019 13:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QMHoky7BpIztbPIx9VbA7YF87db/FXoawkjiF+Gg/UI=; b=gFwRaPbCKhiv0u42PwplV3Bj1f7Avali+hQACaBrYB+tlXcOJNY2Jgu/SmyU9+7EAC bqGNoNM5nFM1GRweVuGNqrhGyGwtHc3SOiaIHhxwzlI5vHV5cmAGwGI4jFzMxFI1schZ JAlkcahqDrm6Rk25l81tdgOqs81OftBWbdvFs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QMHoky7BpIztbPIx9VbA7YF87db/FXoawkjiF+Gg/UI=; b=qdgjTUqlHYDcTQ5NHW1sC/gx1OIKTqrOBBF4tAegl5wNjF18sRoYmEGU4u5IBKgrki oUeYqwM2UERnbKB8ZW/lWgZ4bXdkOC8PmNTGVpq8lm/diZj64WZ6N5Sp33P6L9ZK1Cod W5jihRNfjYPWlYgCQ+slN9dQF6fKvim6fe1UXZRhnsa3mfoMx5UGuSp/H0eM0rLytBBl J1SR8CKk23cm/0o1zypnfEfrym3IXBvpmuBad4TjwlgzCVwu588cQSnDtVg65ESR3FY8 uj43/rnCEFx/9gkPHVayJvjy+XeIuoSWvA6gzlAbJ2hwa4DWa1Q1b/uRwWpGxHd9J1Dx cQdw== X-Gm-Message-State: APjAAAXsI888+DcMPbcRO8cTfMkUzBnNiK9jrWgejvYxyyrAZCqxgVGi JHWg4oxbZ1ToCYbYH/ObUTDfpDq5rw8= X-Google-Smtp-Source: APXvYqxfKXLC2f0eOBL3h87w4grXBsrd1V8YolNu3Zg2TgYegcSIsj6HwZ1dlCgVsRvvWTTVjxOQiQ== X-Received: by 2002:ac2:4d17:: with SMTP id r23mr39829165lfi.130.1560457600944; Thu, 13 Jun 2019 13:26:40 -0700 (PDT) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com. [209.85.167.48]) by smtp.gmail.com with ESMTPSA id e8sm150172lfc.27.2019.06.13.13.26.39 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 13:26:40 -0700 (PDT) Received: by mail-lf1-f48.google.com with SMTP id u10so84480lfm.12 for ; Thu, 13 Jun 2019 13:26:39 -0700 (PDT) X-Received: by 2002:ac2:5b0c:: with SMTP id v12mr32906784lfn.184.1560457599101; Thu, 13 Jun 2019 13:26:39 -0700 (PDT) MIME-Version: 1.0 References: <20190529125220.17066-1-tiwai@suse.de> <20190529125220.17066-3-tiwai@suse.de> <20190613174938.GA260350@google.com> <20190613183835.GA16432@google.com> In-Reply-To: <20190613183835.GA16432@google.com> From: Brian Norris Date: Thu, 13 Jun 2019 13:26:27 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] mwifiex: Abort at too short BSS descriptor element To: Takashi Iwai Cc: linux-wireless , Amitkumar Karwar , Nishant Sarmukadam , Ganapathi Bhat , Xinming Hu , Kalle Valo , huangwen@venustech.com.cn, Solar Designer , Marcus Meissner Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Jun 13, 2019 at 11:38 AM Brian Norris wrote: > So, I might say: > > /* Vendor IEs must at least contain the OUI. */ > if (total_ie_len < offsetof(struct ieee80211_vendor_ie, oui_type)) > return -EINVAL; > > /* If the IE still isn't long enough, it's not a match. */ > if (element_len < sizeof(wpa_oui)) > continue; That would of course need to be break, not continue, to properly skip to the next IE. Brian