From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE16BC00A89 for ; Tue, 3 Nov 2020 00:06:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 846FE20870 for ; Tue, 3 Nov 2020 00:06:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hv08MmKq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbgKCAGc (ORCPT ); Mon, 2 Nov 2020 19:06:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbgKCAGc (ORCPT ); Mon, 2 Nov 2020 19:06:32 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BA39C061A47 for ; Mon, 2 Nov 2020 16:06:32 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id l28so19765474lfp.10 for ; Mon, 02 Nov 2020 16:06:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WHMOmkhlRWyq97AfxS2rXTffakjk5zbzZZUU7niR7ko=; b=hv08MmKqPW2kwHXqrNQp2ucUSP5RIUEfSR109ZFv/+GCfvLMMs748r0m1pga8q2tP7 NKctrAbp0S6uaLSATDuyAfO2MPnGC4c4ilXwVCDYmawkODWJXJ/TkvVBDFuStFWWuL1R ySxawLXlGOyaudd+de2xvN3RGV4tNKoNyIGq8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WHMOmkhlRWyq97AfxS2rXTffakjk5zbzZZUU7niR7ko=; b=aup6QEEAZIjPSyrpzwPCk+LQ0QHezBPaU5feYYgpsq0kGWKSZoES3jn+Iq9RVSyxM8 xCefxKncPRZMqt6Brip0Hf3mJSqhIv0VR7OK8b5XXu8hZTTBKA2GpqOp34ZLtc5gT3o4 OUj7OFIoVToyVcN+P3UtSChqwqLH1GAJlttOD4fz2TZ6fhAGNCe9fH4Rmdb+C7CoNyF2 Vj089/Ep95R9LSy/ejuL5yh9H3FPCXIy28nnZjktGt8Ts6unOxnqLKXxBcUp7BPiop7p Yk0XzN4q2H95IWdC/TBvZzSBtPSE53l5yMgjhxxZO2UQvARsVLmXiJzk+FsHnWmX/7vu KsXg== X-Gm-Message-State: AOAM533GU+ZIaeHBvB8Slkg0NIg7D7Ysg7wQDiHFMTQTPfTwM036f3bM X4x15bFnSXpZL1HAeGUSqPEicodeBJTDbw== X-Google-Smtp-Source: ABdhPJxu2KGpLvVWhkpZf6kP3O8B+eAv1g8EV2XUOrcFUie2kxyZdH7XsNLC0vRF/hQepQ5oIoJokQ== X-Received: by 2002:ac2:59de:: with SMTP id x30mr6271373lfn.19.1604361990399; Mon, 02 Nov 2020 16:06:30 -0800 (PST) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id t66sm2912418lff.85.2020.11.02.16.06.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Nov 2020 16:06:29 -0800 (PST) Received: by mail-lf1-f43.google.com with SMTP id 141so19809922lfn.5 for ; Mon, 02 Nov 2020 16:06:28 -0800 (PST) X-Received: by 2002:a19:41d7:: with SMTP id o206mr7188801lfa.396.1604361987822; Mon, 02 Nov 2020 16:06:27 -0800 (PST) MIME-Version: 1.0 References: <20201102112410.1049272-1-lee.jones@linaro.org> <20201102112410.1049272-42-lee.jones@linaro.org> In-Reply-To: <20201102112410.1049272-42-lee.jones@linaro.org> From: Brian Norris Date: Mon, 2 Nov 2020 16:06:15 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown To: Lee Jones Cc: Kalle Valo , Linux Kernel , Yan-Hsuan Chuang , "David S. Miller" , Jakub Kicinski , linux-wireless , "" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Nov 2, 2020 at 3:25 AM Lee Jones wrote: > --- a/drivers/net/wireless/realtek/rtw88/pci.h > +++ b/drivers/net/wireless/realtek/rtw88/pci.h > @@ -212,6 +212,10 @@ struct rtw_pci { > void __iomem *mmap; > }; > > +int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id); > +void rtw_pci_remove(struct pci_dev *pdev); > +void rtw_pci_shutdown(struct pci_dev *pdev); > + > These definitions are already in 4 other header files: drivers/net/wireless/realtek/rtw88/rtw8723de.h drivers/net/wireless/realtek/rtw88/rtw8821ce.h drivers/net/wireless/realtek/rtw88/rtw8822be.h drivers/net/wireless/realtek/rtw88/rtw8822ce.h Seems like you should be moving them, not just adding yet another duplicate. Brian