From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40614C433C1 for ; Tue, 23 Mar 2021 01:22:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0509F61972 for ; Tue, 23 Mar 2021 01:22:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231476AbhCWBVi (ORCPT ); Mon, 22 Mar 2021 21:21:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbhCWBVM (ORCPT ); Mon, 22 Mar 2021 21:21:12 -0400 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7E3EC061574 for ; Mon, 22 Mar 2021 18:21:11 -0700 (PDT) Received: by mail-oi1-x22e.google.com with SMTP id c16so6367848oib.3 for ; Mon, 22 Mar 2021 18:21:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JYxYqwBBeANyqWyQGmvwdqYnwLRNZNV58JDTVavfLTc=; b=a6JdwhHNlMdGaVeyHRZVJp6OtC/hlOt2kSI6OhN2ddlOaHVxVeZeQ8HV+E3FTvmvQI pH1SrynTesuBahTBNhFHiYEUSrRpIW+SEGg/Om+b8Jo2ibJxfOS4B1Nd+F1pWFpuNAjM 1XKffvMC9iWDlAG/WJRZCqZ15ztaMjjuJsuMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JYxYqwBBeANyqWyQGmvwdqYnwLRNZNV58JDTVavfLTc=; b=GTvHfqzzIWrN751/S/HaNMO3EFT4cConrn4NhTLsMknEu04OR56OnzKstBAwKTxTGW GHXaxSC2a6FbQcdaWhS7lDWdM+pF8uKMcOcE72RkZ6rO0irJ+KBeG7XhHVUUDf2h2t82 J6+pDyrnxQfDfoFfL4T2Yu523btujNlMuQJmBQng5uy38XEX65ty4INMAGG5ka7uJefA 1Fz4yEQzYuBK3ncPzZngXPkmKyMdDo3uZhYeRvlNAUDn/ecVwYxOlIlRLyHhD3UyD5Wf /uje2uUwy1Wav98/fKWF43x2KTTcJ5A5vH2x1GsTIYCw1bMn66eKYGev3h2uXlnxvDRm gwNA== X-Gm-Message-State: AOAM533M0bg/XKbOgnsXYDTHtxAxEOdOuKJ3iTawau7TfIzVQRSmsnuz x6FcgtZxutaDQOV2FpOgr76U8mkbSeSlXw== X-Google-Smtp-Source: ABdhPJzvHi8BBirNv4K9hqQIRl6iC5DaDM6S+HhzHk6KlMQEW+jMaMbfW24dAlzqkXobRCBdriofXQ== X-Received: by 2002:a54:4507:: with SMTP id l7mr1337164oil.165.1616462471405; Mon, 22 Mar 2021 18:21:11 -0700 (PDT) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com. [209.85.210.45]) by smtp.gmail.com with ESMTPSA id m14sm3951045otn.69.2021.03.22.18.21.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 18:21:11 -0700 (PDT) Received: by mail-ot1-f45.google.com with SMTP id w31-20020a9d36220000b02901f2cbfc9743so17644477otb.7 for ; Mon, 22 Mar 2021 18:21:10 -0700 (PDT) X-Received: by 2002:a9d:1b70:: with SMTP id l103mr2239864otl.203.1616462470404; Mon, 22 Mar 2021 18:21:10 -0700 (PDT) MIME-Version: 1.0 References: <1595351666-28193-1-git-send-email-pillair@codeaurora.org> <1595351666-28193-3-git-send-email-pillair@codeaurora.org> <13573549c277b34d4c87c471ff1a7060@codeaurora.org> <04d7301d5ad7555a0377c7df530ad8522fc00f77.camel@sipsolutions.net> <1f2726ff-8ba9-5278-0ec6-b80be475ea98@nbd.name> <06a4f84b-a0d4-3f90-40bb-f02f365460ec@candelatech.com> In-Reply-To: <06a4f84b-a0d4-3f90-40bb-f02f365460ec@candelatech.com> From: Brian Norris Date: Mon, 22 Mar 2021 18:20:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 2/7] ath10k: Add support to process rx packet in thread To: Ben Greear Cc: Felix Fietkau , Johannes Berg , Rajkumar Manoharan , Rakesh Pillai , ath10k , linux-wireless , Linux Kernel , Kalle Valo , "David S. Miller" , Jakub Kicinski , "" , Doug Anderson , Evan Green Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Mar 22, 2021 at 4:58 PM Ben Greear wrote: > On 7/22/20 6:00 AM, Felix Fietkau wrote: > > On 2020-07-22 14:55, Johannes Berg wrote: > >> On Wed, 2020-07-22 at 14:27 +0200, Felix Fietkau wrote: > >> > >>> I'm considering testing a different approach (with mt76 initially): > >>> - Add a mac80211 rx function that puts processed skbs into a list > >>> instead of handing them to the network stack directly. > >> > >> Would this be *after* all the mac80211 processing, i.e. in place of the > >> rx-up-to-stack? > > Yes, it would run all the rx handlers normally and then put the > > resulting skbs into a list instead of calling netif_receive_skb or > > napi_gro_frags. > > Whatever came of this? I realized I'm running Felix's patch since his mt76 > driver needs it. Any chance it will go upstream? If you're asking about $subject (moving NAPI/RX to a thread), this landed upstream recently: http://git.kernel.org/linus/adbb4fb028452b1b0488a1a7b66ab856cdf20715 It needs a bit of coaxing to work on a WiFi driver (including: WiFi drivers tend to have a different netdev for NAPI than they expose to /sys/class/net/), but it's there. I'm not sure if people had something else in mind in the stuff you're quoting though. Brian