From: Brian Norris <briannorris@chromium.org>
To: Stefan Agner <stefan@agner.ch>
Cc: amit karwar <amitkarwar@gmail.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
huxinming820@gmail.com, Kalle Valo <kvalo@codeaurora.org>,
davem@davemloft.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mwifiex: don't print error message on coex event
Date: Tue, 29 Jan 2019 10:52:44 -0800 [thread overview]
Message-ID: <CA+ASDXPawX9QnHG-y6HYdhKSZbzzTzYpwt_oMaXPz5+pqC5Ddg@mail.gmail.com> (raw)
In-Reply-To: <20190128154310.17322-1-stefan@agner.ch>
On Mon, Jan 28, 2019 at 7:43 AM Stefan Agner <stefan@agner.ch> wrote:
>
> The BT coex event is not an error condition. Don't print an error
> message in this case. The same even in sta_event.c prints a
> message using the debug level already.
For some reason, that one (and a handful of others) uses dev_dbg()
instead of mwifiex_dbg() with an appropriate mask (e.g., EVENT). But
mwifiex_dbg() seems preferable for consistency.
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Brian Norris <briannorris@chromium.org>
> ---
> drivers/net/wireless/marvell/mwifiex/uap_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/uap_event.c b/drivers/net/wireless/marvell/mwifiex/uap_event.c
> index e86217a6b9ca..ca759d9c0253 100644
> --- a/drivers/net/wireless/marvell/mwifiex/uap_event.c
> +++ b/drivers/net/wireless/marvell/mwifiex/uap_event.c
> @@ -300,7 +300,7 @@ int mwifiex_process_uap_event(struct mwifiex_private *priv)
> mwifiex_11h_handle_radar_detected(priv, adapter->event_skb);
> break;
> case EVENT_BT_COEX_WLAN_PARA_CHANGE:
> - dev_err(adapter->dev, "EVENT: BT coex wlan param update\n");
> + mwifiex_dbg(adapter, EVENT, "event: BT coex wlan param update\n");
> mwifiex_bt_coex_wlan_param_update_event(priv,
> adapter->event_skb);
> break;
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-01-29 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 15:43 [PATCH] mwifiex: don't print error message on coex event Stefan Agner
2019-01-29 18:52 ` Brian Norris [this message]
2019-02-08 15:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+ASDXPawX9QnHG-y6HYdhKSZbzzTzYpwt_oMaXPz5+pqC5Ddg@mail.gmail.com \
--to=briannorris@chromium.org \
--cc=amitkarwar@gmail.com \
--cc=davem@davemloft.net \
--cc=gbhat@marvell.com \
--cc=huxinming820@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).