From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71CD5FA3728 for ; Thu, 17 Oct 2019 03:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4758C2064A for ; Thu, 17 Oct 2019 03:17:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nMwzx3K3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404522AbfJQDRs (ORCPT ); Wed, 16 Oct 2019 23:17:48 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:33665 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730479AbfJQDRs (ORCPT ); Wed, 16 Oct 2019 23:17:48 -0400 Received: by mail-qt1-f195.google.com with SMTP id r5so1511087qtd.0 for ; Wed, 16 Oct 2019 20:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zfG7ZLV6gt6IG6KOv7MQIlUlPONYymvz8IlPeVuwwCg=; b=nMwzx3K3NL3cQy45ief6pSitotCCjIl+6ftpWEUcLTDocPexdcW2GlmyidBcrsCJvs IoJ2khLA5w9tvB0HaAqTo7nS8I0QJAum2Oiwbl0U9cr9NSdnvJi0Nyw4a4ttRt2MsUkT 0Dn07vOWEuGo+P5jiToi8NuEvLzlHZkKPtdc8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zfG7ZLV6gt6IG6KOv7MQIlUlPONYymvz8IlPeVuwwCg=; b=r9VYHrK9yHCj12uWWGz2R8FOOZ7lWpOCIhNNsYPIr+68voo0hZfaNgFpB9fDDkFinQ AdHgz+FgSPZFb++A58WCWbFCM/Raw0mzZhVAZqnDFmSZRRaxMd+w8oPNsQJJ40MVOb3D +MV11oguFs0h9Zk6d+OA1xyCKSExBt5EiIhRfMjeC8zI3h1db/EBWC54JXM2AeYJzif2 N+ghzR4BvYwArqNpPcFs6gUI12FgwcLD8T9X0AgoXT/8N7wQzLKYkCrvG38rUO2b0Cjb bdzpxBKRyK2D6j5BEUJS/4nihT5kNxP2VDSUinK7l4OoCKvd1Q1UEKNhkwN2pUAm/4YL 7pfQ== X-Gm-Message-State: APjAAAWnakPGFOxvGqLfGUe6+VSkRalCullXeVMPZeKJcCakFfiCAm03 +LhH+yYRZdPpu9XlmXdAe99B3/Qfhuk= X-Google-Smtp-Source: APXvYqw6wsCIl5K1MVGorR2r/nDmQoK/HFVqE5OaTSWJucXhljRxqeMfWq+X2jOUt1ObxZqP3WOgkg== X-Received: by 2002:a0c:fa49:: with SMTP id k9mr1563173qvo.239.1571282266475; Wed, 16 Oct 2019 20:17:46 -0700 (PDT) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com. [209.85.160.177]) by smtp.gmail.com with ESMTPSA id x8sm407541qkx.77.2019.10.16.20.17.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 20:17:45 -0700 (PDT) Received: by mail-qt1-f177.google.com with SMTP id n17so1470006qtr.4 for ; Wed, 16 Oct 2019 20:17:45 -0700 (PDT) X-Received: by 2002:ac8:529a:: with SMTP id s26mr1575999qtn.238.1571282265026; Wed, 16 Oct 2019 20:17:45 -0700 (PDT) MIME-Version: 1.0 References: <20191016123301.2649-1-yhchuang@realtek.com> <20191016123301.2649-5-yhchuang@realtek.com> In-Reply-To: From: Brian Norris Date: Wed, 16 Oct 2019 20:17:32 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/6] rtw88: update regulatory settings implementaion To: Tony Chuang Cc: Kalle Valo , linux-wireless Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Oct 16, 2019 at 7:55 PM Tony Chuang wrote: > > From: Brian Norris > > > > On Wed, Oct 16, 2019 at 5:33 AM wrote: > > > This also supports user regulatory hints, and it should only be > > > enabled for specific distributions that need this to correct > > > the cards reglutory. ... > > There should be a pretty high bar for introducing either new CONFIG_* > > options or module parameters, in my opinion, and I'm not sure you > > really satisfied it. Why "should only be enabled" by certain > > distributions? Your opinion? If it's the technical limitation you > > refer to ("efuse settings"), then just detect the efuse and prevent > > user hints only on those modules. > > > > Because the efuse/module does not contain the information if the > user's hint is allowed. But sometimes distributions require to set the > regulatory via "NL80211_CMD_SET_REG". > So we are leaving the CONFIG_* here for some reason that needs it. Is there ever a case where user hint is not allowed? For what reason? If not efuse, then what? Or alternatively: if someone sets CONFIG_RTW88_REGD_USER_REG_HINTS=y, then what problems will they have? Technical problems (e.g., firmware will crash on certain modules) or problems? (If "" means "legal", then just blink twice to acknowledge. Or just don't answer.) Brian