linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Kazior <michal.kazior@tieto.com>
To: voncken <cedric.voncken@acksys.fr>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: ATH10K and VLAN : Frame with VLAN tag are not sent
Date: Fri, 5 Jun 2015 11:46:03 +0200	[thread overview]
Message-ID: <CA+BoTQkQyTbgctPOTSvLH76+YKkjvYySJSYtGszJ3TT35-uXQQ@mail.gmail.com> (raw)
In-Reply-To: <01f701d09f71$47ae9910$d70bcb30$@acksys.fr>

On 5 June 2015 at 11:23, voncken <cedric.voncken@acksys.fr> wrote:
[...]
>> I see no reason why this should fail. The dot1q encapsulation shouldn't
>> influence how firmware behaves.. but maybe I'm wrong.
>>
>> It's still unclear to me what your topology looks like. Perhaps you're
>> having problem with environmental configuration itself? Did you try other
>> Wi-Fi device (e.g. ath9k) instead of ath10k?
> Yes I tested with ath9k wireless card, the same configuration works.
>
> I did an interesting test. With ostinato software I generate an ICMP frame without vlan tag. I changed the ethertype in the frame.
> I tried with the ethertype 0x800 (IP), 0x801, 0x8892 (PROFINET), 0x8100 (dot1q), 0x0600. All frames are sent except when the ethertype is set to 0x8100. It seems the firmware do not accept the ethertype 0x8100.

Interesting. This may suggest firmware actually doesn't handle dot1q
VLAN tagging properly in NWifi Tx encap mode. Can you try changing it
to 802.3 encap and re-test, please?

--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3172,7 +3172,7 @@ ath10k_tx_h_get_txmode(struct ath10k *ar, struct
ieee80211_vif *vif,
        if (ieee80211_is_data_present(fc) && sta && sta->tdls)
                return ATH10K_HW_TXRX_ETHERNET;

-       return ATH10K_HW_TXRX_NATIVE_WIFI;
+       return ATH10K_HW_TXRX_ETHERNET;
 }

Note: Your backports may not have the necessary code.. In which case
it'll be difficult to do this the easy way. If that's the case I
suggest you get latest backports or generate them yourself from the
latest kvalo/ath master.


Michał

  reply	other threads:[~2015-06-05  9:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  7:55 ATH10K and VLAN : Frame with VLAN tag are not sent voncken
2015-06-05  8:53 ` Michal Kazior
2015-06-05  9:23   ` voncken
2015-06-05  9:46     ` Michal Kazior [this message]
2015-06-05 10:46       ` voncken
2015-06-05 10:52         ` Michal Kazior
2015-06-05 12:30           ` Michal Kazior
2015-06-05 14:07             ` voncken
2015-06-05 16:26             ` voncken
2015-06-11  8:34               ` Michal Kazior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+BoTQkQyTbgctPOTSvLH76+YKkjvYySJSYtGszJ3TT35-uXQQ@mail.gmail.com \
    --to=michal.kazior@tieto.com \
    --cc=ath10k@lists.infradead.org \
    --cc=cedric.voncken@acksys.fr \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).